On Thu, Mar 09, 2006 at 09:44:51AM +0200, Ville Skyttä wrote:
I don't quite understand what makes writing an external script
and then
modifying it from the specfile better than just emitting the script
completely from the .spec in %prep, given that the script will usually
be just a few lines.
I'm definitely not saying it is better. It's a little bit
cleaner-looking maybe.
> Source1: filter-requires.sh
For a guideline, that's a too generic filename.
%{name}-filter-requires.sh would be better.
I changed it to that in cpanspec (just committed to CVS if you feel
like fighting sourceforge's CVS).
> %define __perl_requires
%%{_tmppath}/%{name}-%{version}-%{release}-%(%{__id_u} -n)-filter-requires
Could possibly use %define __perl_requires %{buildroot}-filter-requires
(untested). The double %% appears to be a typo.
It is.
Steve
--
Steven Pritchard - K&S Pritchard Enterprises, Inc.
Email: steve(a)kspei.com
http://www.kspei.com/
Phone: (618)398-3000 Mobile: (618)567-7320