[Bug 1127570] New: No fish completion

List overview All Threads
Download

newer

older

File kubernetes-b2f287c.tar.gz...

[kubernetes] patch kubelet service...

Red Hat Bugzilla

7 Aug 2014 7 Aug '14

2:31 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1127570

Bug ID: 1127570 Summary: No fish completion Product: Fedora Version: 20 Component: docker-io Assignee: lsm5@fedoraproject.org Reporter: yajo.sk8@gmail.com QA Contact: extras-qa@fedoraproject.org CC: admiller@redhat.com, golang@lists.fedoraproject.org, hushan.jia@gmail.com, jperrin@centos.org, lsm5@fedoraproject.org, mattdm@redhat.com, mgoldman@redhat.com, s@shk.io, vbatts@redhat.com

Description of problem: Cannot use autocompletion whith fish shell

Version-Release number of selected component (if applicable): fish-2.1.0-9.fc20.x86_64 docker-io-1.0.0-9.fc20.x86_64

How reproducible: Write `docker [TAB]` using fish shell.

Actual results: Shows directories in CWD.

Expected results: attach events import load pull run tag build export info login push save top commit help insert logs restart search version cp history inspect port rm start wait diff images kill ps rmi stop

Additional info: Current version of Docker provides it: https://github.com/docker/docker/blob/v1.0.0/contrib/completion/fish/docker....

-- You are receiving this mail because: You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

7 Aug 7 Aug

12:07 p.m.

New subject: [Bug 1127570] No fish completion

https://bugzilla.redhat.com/show_bug.cgi?id=1127570

Lokesh Mandvekar lsm5@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED

--- Comment #1 from Lokesh Mandvekar lsm5@fedoraproject.org --- Hi,

Can you test this rpm please: https://lsm5.fedorapeople.org/docker-io-1.1.2-3.fc20.x86_64.rpm

The rawhide version of this doesn't seem to work for me. I see this on fish:

source: Error while reading file “/usr/share/fish/completions/docker.fish”

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

8 Aug 8 Aug

2:11 a.m.

New subject: [Bug 1127570] No fish completion

https://bugzilla.redhat.com/show_bug.cgi?id=1127570

--- Comment #2 from Yajo yajo.sk8@gmail.com --- (In reply to Lokesh Mandvekar from comment #1)

...

Hi,

Can you test this rpm please: https://lsm5.fedorapeople.org/docker-io-1.1.2-3.fc20.x86_64.rpm

The rawhide version of this doesn't seem to work for me. I see this on fish:

source: Error while reading file “/usr/share/fish/completions/docker.fish”

The same for me.

The weird thing is that I copied https://raw.githubusercontent.com/docker/docker/v1.0.0/contrib/completion/fi... to ~/.config/fish/completions/docker.fish and it worked fine. Well, not as fine as the bash completion, but at least it's something.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

8:52 a.m.

New subject: [Bug 1127570] No fish completion

https://bugzilla.redhat.com/show_bug.cgi?id=1127570

--- Comment #3 from Matthew Miller mattdm@redhat.com --- This is problematic. We don't want docker to _require_ fish, but that's what owns the /usr/share/fish/completions directory

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

10:16 a.m.

New subject: [Bug 1127570] No fish completion

https://bugzilla.redhat.com/show_bug.cgi?id=1127570

--- Comment #4 from Lokesh Mandvekar lsm5@fedoraproject.org --- Hmm, looks like it'd be better to have docker.fish included in upstream fish /fish rpm ?

(Same should also apply to zsh in that case (my bad))

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

19 Aug 19 Aug

8:19 a.m.

New subject: [Bug 1127570] No fish completion

https://bugzilla.redhat.com/show_bug.cgi?id=1127570

--- Comment #5 from Yajo yajo.sk8@gmail.com --- That seems to be fish's way: https://github.com/fish-shell/fish-shell/tree/master/share/completions

Other option is to make a separate package.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

11:53 a.m.

New subject: [Bug 1127570] No fish completion

https://bugzilla.redhat.com/show_bug.cgi?id=1127570

--- Comment #6 from Lokesh Mandvekar lsm5@fedoraproject.org --- Hmm, looks like docker completion is already in master https://github.com/fish-shell/fish-shell/blob/master/share/completions/docke... , so it should probably show up in a fish update

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

12:25 p.m.

New subject: [Bug 1127570] No fish completion

https://bugzilla.redhat.com/show_bug.cgi?id=1127570

Lokesh Mandvekar lsm5@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

17 Dec 17 Dec

1:36 p.m.

New subject: [Bug 1127570] No fish completion

https://bugzilla.redhat.com/show_bug.cgi?id=1127570

Lokesh Mandvekar lsm5@redhat.com changed:

--- Comment #7 from Lokesh Mandvekar lsm5@redhat.com --- I'll be adding fish completion in a docker-fish subpackage.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

1:47 p.m.

New subject: [Bug 1127570] No fish completion

https://bugzilla.redhat.com/show_bug.cgi?id=1127570

--- Comment #8 from Lokesh Mandvekar lsm5@redhat.com --- hmm, let me test this before committing to add it :| . My guess is it would conflict with the file already installed via fish.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

15 Jan 15 Jan

3:35 p.m.

New subject: [Bug 1127570] No fish completion

https://bugzilla.redhat.com/show_bug.cgi?id=1127570

Lokesh Mandvekar lsm5@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA

--- Comment #9 from Lokesh Mandvekar lsm5@redhat.com --- This has been included since 1.4.1-1 though these haven't landed in stable yet. Hopefully we'll get a stable push for 1.4.1-1 soon :|

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

16 Jan 16 Jan

2:57 a.m.

New subject: [Bug 1127570] No fish completion

https://bugzilla.redhat.com/show_bug.cgi?id=1127570

--- Comment #10 from Yajo yajo.sk8@gmail.com --- (In reply to Lokesh Mandvekar from comment #9)

...

This has been included since 1.4.1-1 though these haven't landed in stable yet. Hopefully we'll get a stable push for 1.4.1-1 soon :|

I'd love to test it. Could you please add the link for adding karma?

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

3:13 a.m.

New subject: [Bug 1127570] No fish completion

https://bugzilla.redhat.com/show_bug.cgi?id=1127570

--- Comment #11 from Lokesh Mandvekar lsm5@redhat.com --- (In reply to Yajo from comment #10)

...

(In reply to Lokesh Mandvekar from comment #9)

...
This has been included since 1.4.1-1 though these haven't landed in stable yet. Hopefully we'll get a stable push for 1.4.1-1 soon :|

I'd love to test it. Could you please add the link for adding karma?

assuming you've switched to f21, please test and add karma here: https://admin.fedoraproject.org/updates/FEDORA-2015-0641/docker-io-1.4.1-5.f...

if you're still on f20, this is probably the one: https://admin.fedoraproject.org/updates/FEDORA-2015-0451/docker-io-1.4.1-4.f... . This version doesn't have the fix for avoiding /.docker (which is coming in a later build for f20), but it should be good RE: fish subpackage.

HTH.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

22 Jan 22 Jan

12:08 p.m.

New subject: [Bug 1127570] No fish completion

https://bugzilla.redhat.com/show_bug.cgi?id=1127570

Lokesh Mandvekar lsm5@redhat.com changed:

--- Comment #12 from Lokesh Mandvekar lsm5@redhat.com --- So, the f21 build has landed in stable. I'm closing this one.

-- You are receiving this mail because: You are on the CC list for the bug.

3551

Age (days ago)

3719

Last active (days ago)

golang@lists.fedoraproject.org

13 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla