golang February 2021

golang@lists.fedoraproject.org

2 participants
11 discussions

[go-rpm-macros] Issue #2: EPEL availability
by Nicolas Mailhot 29 Mar '24

29 Mar '24

nim reported a new issue against the project: `go-rpm-macros` that you are following: `` The macro code needs massaging to also work on EPEL. Most of the work is spec side since some of the macros are going to collide with the ones provided by previous iterations of Go macro packages `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/2

2 4

[go-rpm-macros] Issue #3: %goprep should apply patches automatically
by Nicolas Mailhot 29 Mar '24

29 Mar '24

nim reported a new issue against the project: `go-rpm-macros` that you are following: `` `%goprep` should apply patches automatically, so there is no convenience gap with `%autosetup`. This is generic work that should be done *redhat-rpm-config* side in forge macros and then reused in`%goprep`. Basically: 1. define a `patch_flags<suffix>` rpm variable holding the parameters that should be passed to `%patch<suffix>` 2. define a `default_flags<suffix>` fallback 3. define a `source_patches<suffix>` holding an ordered space separated list of patch suffixes associated with a particular forge/go source. And then write the usual lua loops to apply it all at the right moment in the spec. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/3

6 9

[go-rpm-macros] PR #20: Use --with-tests when running checks also.
by Elliott Sales de Andrade 05 Sep '21

05 Sep '21

qulogic opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Use --with-tests when running checks also. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/20

1 2

[go-rpm-macros] PR #23: macros: Accept options for %gotest
by Alexander Todorov 21 Jun '21

21 Jun '21

atodorov opened a new pull-request against the project: `go-rpm-macros` that you are following: `` macros: Accept options for %gotest `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/23

4 7

[go-rpm-macros] Issue #25: Consider using -trimpath
by Debarshi Ray 26 Apr '21

26 Apr '21

rishi reported a new issue against the project: `go-rpm-macros` that you are following: `` See [this](https://github.com/containers/toolbox/pull/448) [Toolbox](https://github.com/containers/toolbox) discussion for context. It might be good to include `-trimpath` in `%gobuild` and `%gobuildflags`. Apparently Arch Linux already uses it. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/25

4 9

[go-rpm-macros] Issue #19: LDFlags Macro Typos
by Brian Exelbierd (bex) 20 Apr '21

20 Apr '21

bex reported a new issue against the project: `go-rpm-macros` that you are following: `` While working with a new package, I needed some LDFlags passed. I am using this construction in my spec: ``` %build LDFLAGS="-X foo=bar " %gobuild ... ``` I have to put the space in quotes at the end as we appear to have space expansion errors. I was talking to @ignatenkobrain and he pointed out: * https://pagure.io/go-rpm-macros/blob/master/f/rpm/macros.d/macros.go-rpm#_3… there is a missing space * https://pagure.io/go-rpm-macros/blob/master/f/rpm/macros.d/macros.go-compil… ${LDFLAGS:-%{?currentgoldflags}} ← should be like that `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/19

3 4

[go-rpm-macros] PR #26: Remove tildes from goname
by Benjamin Lowry 20 Apr '21

20 Apr '21

blowry opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Remove tildes from goname `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26

6 13

Alternative method to disable failing tests
by Robert-André Mauchin 17 Mar '21

17 Mar '21

Hi, To my knowledge, in the future Go modules macros (which will hopefully be available at some point in the future), we won't be able to pass -d or -t to %gocheck to disable some test directory. In order to tackle the problem of failing tests, I devised an alternative method to disable failing tests with awk: for test in "TestRestart" \ "TestStop" \ "TestActive" \ ; do awk -i inplace '/^func.*'"$test"'/ { print; print "\treturn"; next}1' $(grep -rl $test) done You can see that it adds a return directly after the test function definition to bypass the test. Instead of return, we could also use: t.Skip("disabled failing test") for test in "TestRestart" \ "TestStop" \ "TestActive" \ ; do awk -i inplace '/^func.*'"$test"'/ { print; print "\tt.Skip(\"disabled failing test\")"; next}1' $(grep -rl $test) done Why I prefer this method: - we don't have to manually create a patch for each test we want to disable, so this is faster and easier. - we don't have to port each patch if there was an update in the test file. - it offers more granularity compared to disabling an entire subdirectory. Eventual problems: - This only works if the format of the test is starting with ^func.* $test and use (t *testing.T) as a parameter (for the second method). I haven't tested this on a sufficient number of package to determine if this is always the case. - It needs awk in the buildroot, it is available by default but let's hope it is not removed in the future. Let me know what you think, Best regards, Robert-André

2 1

Fedora: Patches in Forge macros - Auto macros - Detached rpm changelogs
by Ben Cotton 04 Mar '21

04 Mar '21

Hi Robert-André and Go SIG, There has been no progress on the Patches in Forge macros change[1], so FESCo deferred it to Fedora 35. Since nim hasn't been seen in a while and you were interested in getting this implemented, would you be willing to take this on? FESCo suggested one approach might be to split the forge macros into a separate package. This would allow them to be updated without redhat-rpm-config maintainers approval. [1] https://fedoraproject.org/wiki/Changes/Patches_in_Forge_macros_-_Auto_macro… Thanks, BC -- Ben Cotton He / Him / His Senior Program Manager, Fedora & CentOS Stream Red Hat TZ=America/Indiana/Indianapolis

2 1

[Fedocal] Reminder meeting : Go SIG Meeting
by jcajka＠fedoraproject.org 27 Feb '21

27 Feb '21

Dear all, You are kindly invited to the meeting: Go SIG Meeting on 2021-03-01 from 19:00:00 to 20:00:00 Europe/Prague At fedora-golang(a)irc.freenode.net The meeting will be about: Meeting of Go SIG. For proposed agenda see the tagged tickets https://pagure.io/GoSIG/go-sig/issues?status=Open&tags=meeting Source: https://apps.fedoraproject.org/calendar/meeting/9758/

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

golang February 2021