golang February 2024

golang@lists.fedoraproject.org

2 participants
10 discussions

[go-rpm-macros] Issue #2: EPEL availability
by Nicolas Mailhot 29 Mar '24

29 Mar '24

nim reported a new issue against the project: `go-rpm-macros` that you are following: `` The macro code needs massaging to also work on EPEL. Most of the work is spec side since some of the macros are going to collide with the ones provided by previous iterations of Go macro packages `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/2

2 4

[go-rpm-macros] Issue #3: %goprep should apply patches automatically
by Nicolas Mailhot 29 Mar '24

29 Mar '24

nim reported a new issue against the project: `go-rpm-macros` that you are following: `` `%goprep` should apply patches automatically, so there is no convenience gap with `%autosetup`. This is generic work that should be done *redhat-rpm-config* side in forge macros and then reused in`%goprep`. Basically: 1. define a `patch_flags<suffix>` rpm variable holding the parameters that should be passed to `%patch<suffix>` 2. define a `default_flags<suffix>` fallback 3. define a `source_patches<suffix>` holding an ordered space separated list of patch suffixes associated with a particular forge/go source. And then write the usual lua loops to apply it all at the right moment in the spec. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/3

6 9

[go-rpm-macros] Issue #36: Renaming BUILDTAGS and LDFLAGS to include GO prefixes
by Link Dupont 29 Mar '24

29 Mar '24

linkdupont reported a new issue against the project: `go-rpm-macros` that you are following: `` In #34 and #35, it was brought up to rename the `BUILDTAGS` variable to `GOBUILDTAGS` in order to be more explicit about the intended use of the variables and to avoid any potential namespace collision with other variables. I looked into what packages are using `BUILDTAGS` today to figure out how much of an impact a rename like this will have. As of this writing, the following packages are using `BUILDTAGS` in some capacity: ``` buildah.spec containernetworking-plugins.spec cri-tools.spec go-compilers.spec golang-github-prometheus-node-exporter.spec golang-github-prometheus.spec grafana.spec hugo.spec moby-engine.spec oci-seccomp-bpf-hook.spec pack.spec podman.spec reg.spec runc.spec skopeo.spec snapd.spec source-to-image.spec stargz-snapshotter.spec syncthing.spec weldr-client.spec ``` And the follow packages use `LDFLAGS`: ``` aerc.spec age.spec butane.spec clash.spec containerd.spec doctl.spec fzf.spec geoipupdate.spec git-lfs.spec golang-github-aliyun-cli.spec golang-github-colinmarc-hdfs-2.spec golang-github-haproxytech-dataplaneapi.spec golang-github-hub.spec golang-github-jsonnet-bundler.spec golang-github-magefile-mage.spec golang-github-prometheus.spec golang-github-rfjakob-gocryptfs.spec golang-github-tdewolff-minify.spec golang-github-theoapp-theo-agent.spec golang-mvdan-editorconfig.spec ignition.spec kiln.spec micro.spec open-policy-agent.spec osbuild-composer.spec rclone.spec reg.spec source-to-image.spec syncthing.spec tinygo.spec vgrep.spec weldr-client.spec ``` I identified these packages by grepping the contents of the [current spec tarball](https://src.fedoraproject.org/repo/rpm-specs-latest.tar.xz). To avoid breaking these packages that are currently using `BUILDTAGS` or `LDFLAGS`, there are two possible approaches I see to safely rename the variables: #### 1. Rebuild everything in a side-tag Patch `go-rpm-macros` to rename `BUILDTAGS` and `LDFLAGS` to `GOBUILDTAGS` and `GOLDFLAGS` respectively. Then patch the above packages and stage them all in a side-tag to update them in one monolithic Bodhi update. #### 2. Support both old and new variables at the same time Patch `go-rpm-macros` to support **both** `BUILDTAGS`/`LDFLAGS` *and* `GOBUILDTAGS`/`GOLDFLAGS` simultaneously. Then patch the above packages over time until everything has been ported over to using `GOBUILDTAGS` and `GOLDFLAGS`, and then drop the old variables from `go-rpm-macros`. I'm not sure how easy either of these approaches will be. They are both moving targets as new packages are constantly getting added. It might just be a constant effort to try and keep on top of all the patches as new packages come along and patches need to be rebased onto their target's changes. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/36

4 5

[go-rpm-macros] Issue #46: %gobuildflags missing double quotation marks
by Petr Hruska 29 Mar '24

29 Mar '24

hruskape reported a new issue against the project: `go-rpm-macros` that you are following: `` It seems that commit https://pagure.io/go-rpm-macros/c/359d80bbfe7f0490fc51c43af8d986863516c5bb?… breaking %gobuildflags usage in spec file. Getting error, as double quotation marks are removed. Specfile section unset LDFLAGS %make_build GOBUILDFLAGS="%{gobuildflags}" Error: + /usr/bin/make -O -j16 V=1 VERBOSE=1 'GOBUILDFLAGS=-buildmode pie -compiler gc -tags=rpm_crashtraceback' ' -ldflags ' -B 0x3433f3bcad171c4e7f8f736da295a9fac8289b8c -compressdwarf=false -extldflags '-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -a -v -x' /usr/bin/make: invalid option -- 'c' /usr/bin/make: invalid option -- 'x' Usage: make [options] [target] ... `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/46

2 3

[go-rpm-macros] PR #41: Convert LDFLAGS to GOLDFLAGS and BUILTAGS to GOBUILDTAGS
by Robert-André Mauchin 15 Mar '24

15 Mar '24

eclipseo opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Convert LDFLAGS to GOLDFLAGS and BUILTAGS to GOBUILDTAGS `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/41

2 1

[go-rpm-macros] PR #63: Use $SOURCE_DATE_EPOCH instead of random bytes
by Zbigniew Jędrzejewski-Szmek 06 Mar '24

06 Mar '24

zbyszek opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Use $SOURCE_DATE_EPOCH instead of random bytes `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63

3 13

[go-rpm-macros] PR #62: Add additional gobuildflags macros
by Maxwell G 29 Feb '24

29 Feb '24

gotmax23 opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Add additional gobuildflags macros `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/62

2 8

[go-rpm-macros] PR #61: %goprep: allow using %autosetup for automatic source unpacking
by Maxwell G 05 Feb '24

05 Feb '24

gotmax23 opened a new pull-request against the project: `go-rpm-macros` that you are following: `` %goprep: allow using %autosetup for automatic source unpacking `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/61

1 1

Trying to get started with a large go package
by Orion Poplawski 02 Feb '24

02 Feb '24

So, Zabbix Agent 2 is written in Go. I'd like to work towards packaging it. My current work in progress is here: https://src.fedoraproject.org/fork/orion/rpms/zabbix/tree/go I'd like to at the start just build with the vendored source, but I'm stuck figuring out how to filter out the currently unpackaged packaged from the %go_generate_buildrequires -a output. Any suggestions? I'm currently getting: No match for argument: golang(git.zabbix.com/ap/plugin-support/conf) No match for argument: golang(git.zabbix.com/ap/plugin-support/log) No match for argument: golang(git.zabbix.com/ap/plugin-support/metric) No match for argument: golang(git.zabbix.com/ap/plugin-support/plugin) No match for argument: golang(git.zabbix.com/ap/plugin-support/plugin/comms) No match for argument: golang(git.zabbix.com/ap/plugin-support/plugin/container) No match for argument: golang(git.zabbix.com/ap/plugin-support/std) No match for argument: golang(git.zabbix.com/ap/plugin-support/tlsconfig) No match for argument: golang(git.zabbix.com/ap/plugin-support/uri) No match for argument: golang(git.zabbix.com/ap/plugin-support/zbxerr) No match for argument: golang(github.com/dustin/gomemcached) No match for argument: golang(github.com/dustin/gomemcached/server) No match for argument: golang(github.com/go-ldap/ldap) No match for argument: golang(github.com/go-ole/go-ole) No match for argument: golang(github.com/go-ole/go-ole/oleutil) No match for argument: golang(github.com/goburrow/modbus) No match for argument: golang(github.com/godror/godror) No match for argument: golang(github.com/mediocregopher/radix/v3) No match for argument: golang(github.com/memcachier/mc/v3) No match for argument: golang(github.com/omeid/go-yarn) No match for argument: golang(github.com/sokurenko/go-netstat/netstat) The above are all in src/go/vendor - can we get %go_generate_buildrequires to ignore the packages there? No match for argument: golang(zabbix.com/internal/agent) No match for argument: golang(zabbix.com/internal/agent/alias) No match for argument: golang(zabbix.com/internal/agent/keyaccess) No match for argument: golang(zabbix.com/internal/agent/remotecontrol) No match for argument: golang(zabbix.com/internal/agent/resultcache) No match for argument: golang(zabbix.com/internal/agent/scheduler) No match for argument: golang(zabbix.com/internal/agent/serverconnector) No match for argument: golang(zabbix.com/internal/agent/serverlistener) No match for argument: golang(zabbix.com/internal/agent/statuslistener) No match for argument: golang(zabbix.com/internal/monitor) No match for argument: golang(zabbix.com/pkg/glexpr) No match for argument: golang(zabbix.com/pkg/itemutil) No match for argument: golang(zabbix.com/pkg/pidfile) No match for argument: golang(zabbix.com/pkg/procfs) No match for argument: golang(zabbix.com/pkg/tls) No match for argument: golang(zabbix.com/pkg/version) No match for argument: golang(zabbix.com/pkg/watch) No match for argument: golang(zabbix.com/pkg/web) No match for argument: golang(zabbix.com/pkg/wildcard) No match for argument: golang(zabbix.com/pkg/wmi) No match for argument: golang(zabbix.com/pkg/zbxcmd) No match for argument: golang(zabbix.com/pkg/zbxcomms) No match for argument: golang(zabbix.com/pkg/zbxlib) No match for argument: golang(zabbix.com/pkg/zbxnet) No match for argument: golang(zabbix.com/pkg/zbxregexp) No match for argument: golang(zabbix.com/plugins) No match for argument: golang(zabbix.com/plugins/external) No match for argument: golang(zabbix.com/plugins/memcached/mockserver) The above are all in src/go - can I get %go_generate_buildrequires to ignore the packages that are part of the source itself? Finally, it seems like %go_generate_buildrequires accepts a few options (-a -z -i) - but I can't find them documented anywhere. Thanks!

1 0

[go-rpm-macros] PR #60: go_mod_vendor: use raw string for regex
by Maxwell G 31 Jan '24

31 Jan '24

gotmax23 opened a new pull-request against the project: `go-rpm-macros` that you are following: `` go_mod_vendor: use raw string for regex `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/60

1 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

golang February 2024