[go-rpm-macros] Issue #3: %goprep should apply patches automatically
by Nicolas Mailhot
nim reported a new issue against the project: `go-rpm-macros` that you are following:
``
`%goprep` should apply patches automatically, so there is no convenience gap with `%autosetup`.
This is generic work that should be done *redhat-rpm-config* side in forge macros and then reused in`%goprep`. Basically:
1. define a `patch_flags<suffix>` rpm variable holding the parameters that should be passed to `%patch<suffix>`
2. define a `default_flags<suffix>` fallback
3. define a `source_patches<suffix>` holding an ordered space separated list of patch suffixes associated with a particular forge/go source.
And then write the usual lua loops to apply it all at the right moment in the spec.
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/issue/3
3 weeks, 6 days
Re: [dev] [changelog] [RPM] cauldron core/release go-rpm-macros-3.0.8-1.mga8
by Neal Gompa
On Mon, Dec 16, 2019 at 12:06 PM Guillaume Rousse <dev(a)ml.mageia.org> wrote:
>
> Le 14/12/2019 à 18:08, Neal Gompa (via dev Mailing List) a écrit :
> > The go-rpm-macros package is supposed to supersede the old one.
> > Someone forgot to retire the go-srpm-macros and go-compilers packages
> > in Fedora...
> So, does anyone oppose to reuploading the go-rpm-macros with proper
> obsolete tag, and without the bogus dependency on redhat-rpm-config
> package ?
>
It should be fine, swap the dependency from redhat-rpm-config to
rpm-mageia-setup-build.
Actually, redhat-rpm-config as a dependency is a bug. It *should*
require system-rpm-config, which is a virtual dependency that allows
us to swap among providers.
I *think* rpm-mageia-setup-build doesn't have the system-rpm-config
Provides yet, but it probably should...
--
真実はいつも一つ!/ Always, there's only one truth!
3 years, 11 months
Re: [dev] [changelog] [RPM] cauldron core/release go-rpm-macros-3.0.8-1.mga8
by Neal Gompa
On Sat, Dec 14, 2019 at 11:44 AM Guillaume Rousse <dev(a)ml.mageia.org> wrote:
>
>
>
> Le 13/12/2019 à 16:30, Thomas Backlund a écrit :
> >
> > Den 13-12-2019 kl. 16:22, skrev Thierry Vignaud (via dev Mailing List):
> >> Le ven. 13 déc. 2019 à 12:18, guillomovitch
> >> <buildsystem-daemon(a)mageia.org> a écrit :
> >>> guillomovitch <guillomovitch> 3.0.8-1.mga8:
> >>> + Revision: 1466186
> >>> - imported package go-rpm-macros
> >> 1) you overwite the existing package :-(
> >>
> >> $ ch go-srpm-macros|less
> >> * Sun Nov 18 2018 pterjan <pterjan> 2-1.mga7
> >> + Revision: 1331116
> >> - imported package go-srpm-macros
> >>
> >> 2) you broke the deps:
> >>
> >> A requested package cannot be installed:
> >> go-srpm-macros-3.0.8-1.mga8.noarch (due to unsatisfied redhat-rpm-config)
> >> Continue installation anyway? (Y/n)
> >
> >
> > and broke the buildsystem :/
> >
> >
> > I've nuked the go-(s)rpm-macros-3.0.8-1.mga8 packages from the repo and
> > restored the go-srpm-macros-2-1.mga7.noarch.rpm and the hdlist
> > re-generation is in progress
> >
> >
> > If you need updated go-srpm-macro package, then please update the
> > already existing go-srpm-macros
> We already have the latest version for go-srpm-macros, which is
> unfortunatly missing some macros required to build latest release of
> git-lfs (at least, following the fedora spec file):
> https://src.fedoraproject.org/rpms/git-lfs/blob/master/f/git-lfs.spec
>
> Fedora apparently have the two packages simultaneously, without any
> conflict/obsolete tag between them:
> https://src.fedoraproject.org/rpms/go-rpm-macros
> https://src.fedoraproject.org/rpms/go-srpm-macros
>
> In order to make future syncing easier, I'd rather replace our current
> package instead of updating it.
The go-rpm-macros package is supposed to supersede the old one.
Someone forgot to retire the go-srpm-macros and go-compilers packages
in Fedora...
--
真実はいつも一つ!/ Always, there's only one truth!
3 years, 11 months