https://bugzilla.redhat.com/show_bug.cgi?id=1096296

Bug ID: 1096296 Summary: man page inaccuracy about --sig-proxy and --tty Product: Red Hat Enterprise Linux 7 Version: 7.1 Component: docker Assignee: lsm5@redhat.com Reporter: ldoktor@redhat.com QA Contact: virt-bugs@redhat.com CC: admiller@redhat.com, golang@lists.fedoraproject.org, lsm5@redhat.com, mattdm@redhat.com, mgoldman@redhat.com, skottler@redhat.com, vbatts@redhat.com, whenry@redhat.com Depends On: 1087697

+++ This bug was initially created as a clone of Bug #1087697 +++

Description of problem: Hi guys,

the man page states: --sig-proxy=true: Proxify all received signal to the process (even in non-tty mode)

But the real behavior is, that sig-proxy doesn't work when --tty=true. It should be mentioned in there, taht --sig-proxy is incompatible with --tty.

Version-Release number of selected component (if applicable): docker-io-0.9.1-1.fc21.x86_64

How reproducible: always

Steps to Reproduce: 1. man docker

Actual results: man page says it works even in non-tty

Expected results: man page warns that --tty can't be used with --sig-proxy

How to verify: 1. docker run --tty=true -i --rm fedora bash -c 'for NUM in `seq 1 64`; do trap "echo Received $NUM, ignoring..." $NUM; done; while :; do sleep 1; done' 2. ps -ax | grep docker 3. kill -SIGUSR1 $PID 4. (with --tty=true no signals are received, when you try the same with --tty=false, signals are proxified and messages are displayed)

--- Additional comment from Lokesh Mandvekar on 2014-04-15 02:11:48 EDT ---

Copying William (he recently got per subcommand manpages merged upstream).

this seems to be the case even in the latest manpage (I'm guessing this was inherited from the original manpage).

William, was there any discussion about this in your PR?

--- Additional comment from Lokesh Mandvekar on 2014-04-15 02:15:31 EDT ---

btw, the 0.10 rpm includes the latest manpages (should be in yum soon)

--- Additional comment from Lukas Doktor on 2014-04-15 04:45:55 EDT ---

Thanks for a quick reply. I tried the docker-io-0.10.0-2.fc20.x86_64 which says: --sig-proxy=true|false: When set to true, proxify all received signals to the process (even in non-tty mode). The default is true.

I'd really like to change it to "only in non-tty" with possible warning that --tty=true is incompatible with --sig-proxy.

--- Additional comment from William Henry on 2014-04-30 15:54:25 EDT ---

I go this text from upstream. I'll check.

--- Additional comment from William Henry on 2014-04-30 16:02:22 EDT ---

Lukas,according to the folks upstream, this is a bug in docker run and attach. It should be as the text suggests.

Can you file a bug upstream with docker? Here: https://github.com/dotcloud/docker/issues

Please just take the information you posted above and post it there.

Thanks. Well spotted.

Best, William

--- Additional comment from Lukas Doktor on 2014-05-02 04:02:01 EDT ---

Upstream tracer:

https://github.com/dotcloud/docker/issues/5547

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1087697 [Bug 1087697] man page inaccuracy about --sig-proxy and --tty