eclipseo commented on the pull-request: `Fix goname generation to match versioning
guildelines` that you are following:
``
I made it so it always uses a _ to separate a version from the import
path when go_use_new_versioning is set and otherwise use a -. Did I not understand what
the FPC asked for?
Where in the FPC does it say this ?
They have either suggested :
Our suggestions are:
If the package names would continue to use a hyphen as separator for the version
specifier ("-vN"), we would like the package suffix to be "-vN" as
well.
If you would like the current Go naming practices to remain in place, we would
consider documenting the exception for using a hyphen as a separator for this purpose.
The other option is to actually respect the guidelines, which is what I wanted to do,
which is no hyphen, just the version number at the end of the package. Of the package ends
with a number, then we add an underscore, then the version number.
Your code is not doing that. You code add a underscore in all cases and does not check
that the package names end with a number or not as far as i understand, which was covered
by the condition in my code:
```if string.find(prior, "%d$") then
return prior .. "_" .. version
else
return prior .. version ```
Also, the lists we have been working off of aren't even all
inclusive. compat-golang-*-devel packages also use this logic:
There is no standalone compat package afaik, all compat packages are subpackages of
standards packages.
There are at least four packages in EPEL 9 that would be impacted by
this change.
I never intended to propagate this change to EPEL. EPEL is stable like this, we almost
never build libraries there.
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/56