Nir Soffer has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
......................................................................
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/62324/6/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:
Line 97: server, parsed_args.sd_uuid)
Line 98:
Line 99: _print_volume_chains(image_chains, volumes_info)
Line 100:
Line 101: server.close()
We should probably somehow make sure this definitely happens - either
put t
We can do:
with closing(server):
...
Line 102:
Line 103:
Line 104: def _connect_to_server(host, port, use_ssl):
Line 105: requestQueues = config.get("addresses",
"request_queues")
Line 102:
Line 103:
Line 104: def _connect_to_server(host, port, use_ssl):
Line 105: requestQueues = config.get("addresses",
"request_queues")
Line 106: requestQueue = requestQueues.split(",")[0]
Keep lowercase names
Line 107: try:
Line 108: return jsonrpcvdscli.connect(
Line 109: requestQueue=requestQueue, host=host, port=port, useSSL=use_ssl)
Line 110: except socket.error as e:
Line 105: requestQueues = config.get("addresses",
"request_queues")
Line 106: requestQueue = requestQueues.split(",")[0]
Line 107: try:
Line 108: return jsonrpcvdscli.connect(
Line 109: requestQueue=requestQueue, host=host, port=port, useSSL=use_ssl)
Formatting: space before and after "="
Not in call
arguments, it is even forbidden by pep8.
Line 110: except socket.error as e:
Line 111: if e[0] == errno.ECONNREFUSED:
Line 112: raise ConnectionRefusedError(
Line 113: "Connection to %s:%s refused" % (host, port))
--
To view, visit
https://gerrit.ovirt.org/62324
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes