Allon Mureinik has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
......................................................................
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/62324/6/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:
PS6, Line 101: server.close()
We should probably somehow make sure this definitely happens - either put the entire thing
under a context manager, in a finally block, etc.
PS6, Line 109: =
Formatting: space before and after "="
--
To view, visit
https://gerrit.ovirt.org/62324
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes