Irit Goihman has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
......................................................................
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/62324/14/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:
Line 121:
Line 122:
Line 123: def _get_volume_info(server, vol_uuid, img_uuid, sd_uuid, sp_uuid):
Line 124: res = _call_server(
Line 125: server.getVolumeInfo, vol_uuid, sp_uuid, sd_uuid, img_uuid)
why do you change this line? please mention it in the commit msg .
Done
Line 126: return res['info']
Line 127:
Line 128:
Line 129: def _get_volumes_chains(server, sd_uuid):
--
To view, visit
https://gerrit.ovirt.org/62324
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes