From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpc
......................................................................
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/62324/18/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:
Line 89: parser.add_argument('-u', '--unsecured',
action='store_false',
Line 90: dest='use_ssl', default=True,
Line 91: help="use unsecured connection")
Line 92: parser.add_argument('-H', '--host',
default='localhost')
Line 93: parser.add_argument('-p', '--port', default=54321)
same 54321, now im more positive that it should follow a constant
Line 94:
Line 95: return parser.parse_args(args=args[1:])
Line 96:
Line 97:
--
To view, visit
https://gerrit.ovirt.org/62324
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes