From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: client: add default value for port parameter
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/67069/1/lib/vdsm/client.py
File lib/vdsm/client.py:
Line 96: from yajsonrpc import stompreactor
Line 97: import yajsonrpc
Line 98:
Line 99:
Line 100: def connect(host, port=54321, use_tls=True, timeout=60):
This is a clinet and the config module maybe not there. We can't
depend on
but we have it also in
https://gerrit.ovirt.org/#/c/62324/18/lib/vdsm/tool/dump_volume_chains.py and in
config.py.in - if one day you will want to change it, you will grep for this number and
change in all those 3 places.. don't you prefer constant?
Line 101: try:
Line 102: client = stompreactor.SimpleClient(host, port, use_tls)
Line 103: except Exception as e:
Line 104: raise ClientError("connect", None, e)
--
To view, visit
https://gerrit.ovirt.org/67069
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id28256a3baa0f57478e7670ff756692015f27303
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes