Irit Goihman has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
......................................................................
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/62324/6/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:
Line 97: with closing(server):
Line 98: image_chains, volumes_info = _get_volumes_chains(
Line 99: server, parsed_args.sd_uuid)
Line 100: _print_volume_chains(image_chains, volumes_info)
Line 101:
We can do:
Done
Line 102:
Line 103: def _connect_to_server(host, port, use_ssl):
Line 104: request_queues = config.get("addresses",
"request_queues")
Line 105: request_queue = request_queues.split(",")[0]
Line 102:
Line 103: def _connect_to_server(host, port, use_ssl):
Line 104: request_queues = config.get("addresses",
"request_queues")
Line 105: request_queue = request_queues.split(",")[0]
Line 106: try:
Keep lowercase names
Done
Line 107: return jsonrpcvdscli.connect(
Line 108: requestQueue=request_queue, host=host, port=port, useSSL=use_ssl)
Line 109: except socket.error as e:
Line 110: if e[0] == errno.ECONNREFUSED:
--
To view, visit
https://gerrit.ovirt.org/62324
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes