https://bugzilla.redhat.com/show_bug.cgi?id=1258940
Bug ID: 1258940 Summary: new versions of perl-Log-Dispatch cause other modules to fail Product: Fedora Version: rawhide Component: perl-Log-Dispatch Severity: medium Assignee: tcallawa@redhat.com Reporter: emmanuel@seyman.fr QA Contact: extras-qa@fedoraproject.org CC: perl-devel@lists.fedoraproject.org, rc040203@freenet.de, tcallawa@redhat.com
Description of problem: For a short while, we've been seeing a number of perl modules FTBFS. These include perl-Log-Dispatch-Config, perl-MooseX-LogDispatch and perl-MooseX-LazyLogDispatch. The one thing they all have in common is that they share a common parent, perl-Log-Dispatch.
As an experiment, I tried to rebuild perl-MooseX-LogDispatch while updating perl-LogDispatch and it started FTBFS-ing when I updated perl-LogDispatch from 2.46 to 2.47. Neither 2.48 nor 2.49 fixed things.
Version-Release number of selected component (if applicable): 2.48-1 (but this started with 2.47)
How reproducible: always
Additional info: I'll file a bug report on rt.cpan.org later today.
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
--- Comment #1 from Ralf Corsepius rc040203@freenet.de --- I can reproduce this issue and believe to have identified the commit to blame.
Reverting the commit below lets perl-Log-Dispatch-Config's testsuite succeed, again: https://github.com/houseabsolute/Log-Dispatch/commit/b92533ceaf813a2b237ab8e...
I haven't tried to furtherly investigate, but I am inclined to believe this change in Log::Display may expose utf8 issues with the packages listed above.
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugzilla.redhat.com | |/show_bug.cgi?id=1258920
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@redhat.com Summary|new versions of |perl-Log-Dispatch >= 2.47 |perl-Log-Dispatch cause |causes other modules to |other modules to fail |fail
--- Comment #2 from Petr Pisar ppisar@redhat.com --- That's because the commit logs into STDERR's file descriptor. It logged into perl's STDERR handle before.
For example Log-Dispatch-Config test ties a scalar variable to the STDERR object in order to redirect the logging I/O into the variable. As a result of the commit, the log messages are printed to /dev/stderr instead of into the $err scalar tied to the STDERR object, and the test fail.
While I can fix Log-Dispatch-Config's tests (even Log-Dispatch's tests were changed in the commit) because the Log::Dispatch::Config is just a simple wrapper around Log::Dispatch constructor, the Log-Dispatch's behavior will remain changed and other code using the module possibly affected.
There is Log-Dispatch's CPAN RT#106605 supposedly fixed in 2.49, but this still does not fix this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
--- Comment #3 from Petr Pisar ppisar@redhat.com --- Because the change is documented as:
+- Add a utf8 flag for Log::Dispatch::Screen. If this is true, then it sets the + ":encoding(UTF-8)" flag on the handle it uses for output (without affecting + STDOUT or STDERR elsewhere). Suggested by Ivan Baidakou.
I believe logging to an independent file handle was an intentional change. Therefore I think upstream will not go back.
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
Emmanuel Seyman emmanuel@seyman.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- External Bug ID| |CPAN 106823
--- Comment #4 from Emmanuel Seyman emmanuel@seyman.fr --- Ticket #106823 has been filed on rt.cpan.org .
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
--- Comment #5 from Ralf Corsepius rc040203@freenet.de --- (In reply to Emmanuel Seyman from comment #4)
Ticket #106823 has been filed on rt.cpan.org .
If what Petr wrote in comments #2 and #3 applies (which I tend to agree to), then I'm inclined to believe the failing modules are subject to an unintentional incompatibility and thus would need to be updated.
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
--- Comment #6 from Emmanuel Seyman emmanuel@seyman.fr --- (In reply to Ralf Corsepius from comment #5)
If what Petr wrote in comments #2 and #3 applies (which I tend to agree to),
JFTR, I agree that Petr is right and that all the other modules are wrong but I'ld like to hear back from the Log-Dispatch maintainers first.
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugzilla.redhat.com | |/show_bug.cgi?id=1259392
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugzilla.redhat.com | |/show_bug.cgi?id=1259396
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
--- Comment #7 from Emmanuel Seyman emmanuel@seyman.fr --- Log-Dispatch 2.50 has been released reverting the behaviour: https://metacpan.org/source/DROLSKY/Log-Dispatch-2.50/Changes#L5
Ralf, the ball's in your court.
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #8 from Ralf Corsepius rc040203@freenet.de --- (In reply to Emmanuel Seyman from comment #7)
Log-Dispatch 2.50 has been released reverting the behaviour: https://metacpan.org/source/DROLSKY/Log-Dispatch-2.50/Changes#L5
Wow, this surprizes me. I had expected a decision into the opposite direction.
The reversion will requires careful testing of all depending packages ;)
Ralf, the ball's in your court.
OK, I'll try to push updates, ASAP.
Formally take this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|tcallawa@redhat.com |rc040203@freenet.de
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
--- Comment #9 from Ralf Corsepius rc040203@freenet.de --- The fc23 build failed.
Seems as if somebody has screwed up perl-ExtUtils-MakeMaker in fc23: ... DEBUG util.py:377: Error: Package: perl-ExtUtils-MakeMaker-7.04-346.fc23.noarch (build) DEBUG util.py:377: Requires: perl(ExtUtils::Command) >= 1.16 ...
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
--- Comment #10 from Petr Pisar ppisar@redhat.com --- I retired perl-ExtUtils-Command in F24, but faulty fedpkg tool blocked it in F23 too. Unblocking https://fedorahosted.org/rel-eng/ticket/6242 was requested.
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
--- Comment #11 from Ralf Corsepius rc040203@freenet.de --- (In reply to Petr Pisar from comment #10)
I retired perl-ExtUtils-Command in F24, but faulty fedpkg tool blocked it in F23 too. Unblocking https://fedorahosted.org/rel-eng/ticket/6242 was requested.
Thanks for the info. To my surprize, a subsequent build ca. 20-30 later succeeded.
No idea if this was thanks to your action or if bodhi/koji/repos are such kind of broken, building has become a lottery - I guess it's the latter ;)
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-Log-Dispatch-2.50-1.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update perl-Log-Dispatch'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14961
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- perl-Log-Dispatch-2.50-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update perl-Log-Dispatch'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14960
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- perl-Log-Dispatch-2.50-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update perl-Log-Dispatch'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14962
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- perl-Log-Dispatch-2.50-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |2.50-1.fc22 Resolution|--- |NEXTRELEASE Last Closed| |2015-09-11 13:22:19
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- perl-Log-Dispatch-2.50-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|2.50-1.fc22 |2.50-1.fc21
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- perl-Log-Dispatch-2.50-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1258940
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|2.50-1.fc21 |2.50-1.fc23
perl-devel@lists.fedoraproject.org