commit b220aa08f8f4d564f70d052ec9adb2d06c48bce3 Author: Paul Howarth paul@city-fan.org Date: Tue Feb 5 16:19:19 2013 +0000
Always use included Module::Install to avoid circular build deps (#906007)
perl-XML-SAX-Writer.spec | 20 +++++++------------- 1 files changed, 7 insertions(+), 13 deletions(-) --- diff --git a/perl-XML-SAX-Writer.spec b/perl-XML-SAX-Writer.spec index abbf6b2..8a29600 100644 --- a/perl-XML-SAX-Writer.spec +++ b/perl-XML-SAX-Writer.spec @@ -1,6 +1,6 @@ Name: perl-XML-SAX-Writer Version: 0.53 -Release: 2%{?dist} +Release: 3%{?dist} Summary: SAX2 Writer License: GPL+ or Artistic Group: Development/Libraries @@ -8,12 +8,10 @@ URL: http://search.cpan.org/dist/XML-SAX-Writer/ Source0: http://www.cpan.org/modules/by-module/XML/XML-SAX-Writer-%%7Bversion%7D.tar.... BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildArch: noarch -BuildRequires: perl(inc::Module::Install) +BuildRequires: perl(Cwd) BuildRequires: perl(Encode) >= 2.12 -%if ! ( 0%{?rhel} ) -BuildRequires: perl(Module::Install::AutoManifest) -BuildRequires: perl(Module::Install::Repository) -%endif +BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(File::Path) BuildRequires: perl(Test::More) >= 0.40 BuildRequires: perl(XML::Filter::BufferText) >= 1.00 BuildRequires: perl(XML::NamespaceSupport) >= 1.00 @@ -25,15 +23,8 @@ A new XML Writer to match the SAX2 effort.
%prep %setup -q -n XML-SAX-Writer-%{version} -rm -r inc -sed -i -e '/^inc// d' MANIFEST find -type f -exec chmod -x {} +
-%if ( 0%{?rhel} ) -sed -i -e '/^auto_set_repository/ d' Makefile.PL -sed -i -e '/^auto_manifest/ d' Makefile.PL -%endif - %build %{__perl} Makefile.PL INSTALLDIRS=vendor make %{?_smp_mflags} @@ -61,6 +52,9 @@ rm -rf %{buildroot} %{_mandir}/man3/*
%changelog +* Tue Feb 5 2013 Paul Howarth paul@city-fan.org - 0.53-3 +- Always use included Module::Install to avoid circular build deps (#906007) + * Fri Nov 23 2012 Jitka Plesnikova jplesnik@redhat.com - 0.53-2 - Drop BR perl(Module::Install::*) for RHEL
On Tue, Feb 05, 2013 at 04:19:56PM +0000, Paul Howarth wrote:
commit b220aa08f8f4d564f70d052ec9adb2d06c48bce3 Author: Paul Howarth paul@city-fan.org Date: Tue Feb 5 16:19:19 2013 +0000
Always use included Module::Install to avoid circular build deps (#906007)
perl-XML-SAX-Writer.spec | 20 +++++++------------- 1 files changed, 7 insertions(+), 13 deletions(-)
Can you show me the cycle? I cannot find why Module::Install::* stuff would need XML::SAX::Writer.
-- Petr
On 05/02/13 16:38, Petr Pisar wrote:
On Tue, Feb 05, 2013 at 04:19:56PM +0000, Paul Howarth wrote:
commit b220aa08f8f4d564f70d052ec9adb2d06c48bc Author: Paul Howarth paul@city-fan.org Date: Tue Feb 5 16:19:19 2013 +0000
Always use included Module::Install to avoid circular build deps (#906007)
perl-XML-SAX-Writer.spec | 20 +++++++------------- 1 files changed, 7 insertions(+), 13 deletions(-)
Can you show me the cycle? I cannot find why Module::Install::* stuff would need XML::SAX::Writer.
There's a lot of them. Remember, these are build dependency cycles, not regular dependency cycles, so things pulled in by test suites take effect. Some samples:
perl-XML-Twig->perl-XML-SAX-Writer->perl-Module-Install-Repository->perl-Path-Class->perl-Test-Perl-Critic->perl-Perl-Critic->perl-List-MoreUtils->perl-Test-LeakTrace->perl-Test-Valgrind->perl-XML-Twig
perl-prefork->perl-Perl-MinimumVersion->perl-Perl-Critic->perl-List-MoreUtils->perl-Test-LeakTrace->perl-Test-Valgrind->perl-XML-Twig->perl-XML-SAX-Writer->perl-Module-Install->perl-Module-ScanDeps->perl-prefork
perl-XML-Twig->perl-XML-SAX-Writer->perl-Module-Install->perl-Test-MinimumVersion->perl-Perl-MinimumVersion->perl-Perl-Critic->perl-List-MoreUtils->perl-Test-LeakTrace->perl-Test-Valgrind->perl-XML-Twig
There's probably more than one place to have broken these cycles, but this way fits in with upstream's build process and doesn't require any bootstrapping conditionals or extra builds at the end of bootstrapping.
Paul.
perl-devel@lists.fedoraproject.org