[Bug 552564] Merge Review: perl-IO-stringy - I/O on in-core objects like strings and arrays for Perl
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552564
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com> 2010-01-15 01:52:08 EST ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1923072
- rpmlint is NOT silent for SRPM and for RPM.
perl-IO-stringy.noarch: W: spurious-executable-perm
/usr/share/doc/perl-IO-stringy-2.110/examples/IO_Scalar_synopsis
perl-IO-stringy.noarch: W: doc-file-dependency
/usr/share/doc/perl-IO-stringy-2.110/examples/IO_Scalar_synopsis /usr/bin/perl
+ source files match upstream url (sha1sum)
3ef94404e51e3a6276ddddcce9ba7bbdd6b76a1f IO-stringy-2.110.tar.gz
+ package meets naming and packaging guidelines.
+ make test gave
All tests successful.
Files=6, Tests=116, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.18 cusr 0.02
csys = 0.24 CPU)
+ Package perl-IO-stringy-2.110-11.fc13.noarch =>
Provides: perl(IO::AtomicFile) = 2.110 perl(IO::InnerFile) = 2.110
perl(IO::Lines) = 2.110 perl(IO::Scalar) = 2.110 perl(IO::ScalarArray) = 2.110
perl(IO::Stringy) = 2.110 perl(IO::Wrap) = 2.110 perl(IO::WrapTie) = 2.110
perl(IO::WrapTie::Master) perl(IO::WrapTie::Slave)
Requires: /usr/bin/perl perl >= 0:5.002 perl >= 0:5.004 perl >= 0:5.005
perl(Carp) perl(Exporter) perl(FileHandle) perl(IO::File) perl(IO::Handle)
perl(IO::Scalar) perl(IO::ScalarArray) perl(IO::WrapTie) perl(Symbol)
perl(overload) perl(strict) perl(vars)
Suggestions:
1) please use macros everywhere so replace rm in following with its macro
/usr/bin/find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
2)change line
%{__chmod} -R u+w %{buildroot}/*
to
%{_fixperms} %{buildroot}/*
3) Fix rpmlint message by adding following to %prep
chmod 644 examples/IO_Scalar_synopsis
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
14 years, 5 months
rpms/perl-Devel-Cover/devel .cvsignore, 1.10, 1.11 perl-Devel-Cover.spec, 1.16, 1.17 sources, 1.10, 1.11
by Tom Callaway
Author: spot
Update of /cvs/pkgs/rpms/perl-Devel-Cover/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv20066
Modified Files:
.cvsignore perl-Devel-Cover.spec sources
Log Message:
0.65
Index: .cvsignore
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Devel-Cover/devel/.cvsignore,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -p -r1.10 -r1.11
--- .cvsignore 13 Jun 2008 20:32:11 -0000 1.10
+++ .cvsignore 14 Jan 2010 23:03:33 -0000 1.11
@@ -1 +1 @@
-Devel-Cover-0.64.tar.gz
+Devel-Cover-0.65.tar.gz
Index: perl-Devel-Cover.spec
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Devel-Cover/devel/perl-Devel-Cover.spec,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -p -r1.16 -r1.17
--- perl-Devel-Cover.spec 7 Dec 2009 08:39:40 -0000 1.16
+++ perl-Devel-Cover.spec 14 Jan 2010 23:03:33 -0000 1.17
@@ -1,6 +1,6 @@
Name: perl-Devel-Cover
-Version: 0.64
-Release: 4%{?dist}
+Version: 0.65
+Release: 1%{?dist}
Summary: Code coverage metrics for Perl
Group: Development/Libraries
@@ -65,6 +65,9 @@ rm -rf $RPM_BUILD_ROOT
%changelog
+* Thu Jan 14 2010 Tom "spot" Callaway <tcallawa(a)redhat.com> - 0.65-1
+- update to 0.65
+
* Mon Dec 7 2009 Stepan Kasal <skasal(a)redhat.com> - 0.64-4
- rebuild against perl 5.10.1
Index: sources
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Devel-Cover/devel/sources,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -p -r1.10 -r1.11
--- sources 13 Jun 2008 20:32:11 -0000 1.10
+++ sources 14 Jan 2010 23:03:33 -0000 1.11
@@ -1 +1 @@
-6d90f2eb1eb64f27f2289be6f51d2d02 Devel-Cover-0.64.tar.gz
+7c83ef4c01b2620137dca7a241cda4d9 Devel-Cover-0.65.tar.gz
14 years, 5 months
rpms/perl-Convert-BinHex/devel perl-Convert-BinHex.spec,1.14,1.15
by Paul Howarth
Author: pghmcfc
Update of /cvs/pkgs/rpms/perl-Convert-BinHex/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv20770
Modified Files:
perl-Convert-BinHex.spec
Log Message:
minor spec issues from merge review (#552554)
Index: perl-Convert-BinHex.spec
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Convert-BinHex/devel/perl-Convert-BinHex.spec,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -p -r1.14 -r1.15
--- perl-Convert-BinHex.spec 4 Dec 2009 02:11:16 -0000 1.14
+++ perl-Convert-BinHex.spec 14 Jan 2010 20:39:11 -0000 1.15
@@ -1,7 +1,7 @@
Name: perl-Convert-BinHex
Version: 1.119
-Release: 11%{?dist}
-Summary: Macintosh BinHex extractor library for Perl
+Release: 12%{?dist}
+Summary: Convert to/from RFC1741 HQX7 (Mac BinHex)
Group: Development/Libraries
License: GPL+ or Artistic
URL: http://search.cpan.org/dist/Convert-BinHex/
@@ -16,7 +16,7 @@ Convert::BinHex extracts data from Macin
%prep
%setup -q -n Convert-BinHex-%{version}
-%{__chmod} -x bin/*.pl docs/Convert/BinHex/*.gif
+%{__chmod} -x bin/*.pl docs/Convert/BinHex/redapple.gif
%{__cp} -a bin examples
%{__perl} -pi -e 's/^use lib .*$//' bin/*.pl
%{__perl} -pi -e 's/^(\(a)ISA.*)/require Exporter; $1/' t/Checker.pm
@@ -28,9 +28,9 @@ Convert::BinHex extracts data from Macin
%install
%{__rm} -rf %{buildroot}
%{__make} pure_install PERL_INSTALL_ROOT=%{buildroot}
-/usr/bin/find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
-/usr/bin/find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
-%{__chmod} -R u+w %{buildroot}/*
+/usr/bin/find %{buildroot} -type f -name .packlist -exec %{__rm} -f {} ';'
+/usr/bin/find %{buildroot} -depth -type d -exec /bin/rmdir {} ';' 2>/dev/null
+%{_fixperms} %{buildroot}
%check
%{__make} test
@@ -42,20 +42,23 @@ Convert::BinHex extracts data from Macin
%defattr(-,root,root,-)
%doc COPYING README docs examples
%{perl_vendorlib}/Convert/
-%{_mandir}/man3/Convert::BinHex.3*
+%{_mandir}/man3/Convert::BinHex.3pm*
%changelog
-* Fri Dec 4 2009 Stepan Kasal <skasal(a)redhat.com> - 1.119-11
+* Thu Jan 14 2010 Paul Howarth <paul(a)city-fan.org> 1.119-12
+- minor spec issues from merge review (#552554)
+
+* Fri Dec 4 2009 Stepan Kasal <skasal(a)redhat.com> 1.119-11
- rebuild against perl 5.10.1
-* Sat Jul 25 2009 Fedora Release Engineering <rel-eng(a)lists.fedoraproject.org> - 1.119-10
-- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
+* Sat Jul 25 2009 Fedora Release Engineering <rel-eng(a)lists.fedoraproject.org> 1.119-10
+- rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
-* Thu Feb 26 2009 Fedora Release Engineering <rel-eng(a)lists.fedoraproject.org> - 1.119-9
-- Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
+* Thu Feb 26 2009 Fedora Release Engineering <rel-eng(a)lists.fedoraproject.org> 1.119-9
+- rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
-* Wed Feb 27 2008 Tom "spot" Callaway <tcallawa(a)redhat.com> - 1.119-8
-- Rebuild for perl 5.10 (again)
+* Wed Feb 27 2008 Tom "spot" Callaway <tcallawa(a)redhat.com> 1.119-8
+- rebuild for perl 5.10 (again)
* Mon Jan 14 2008 Tom "spot" Callaway <tcallawa(a)redhat.com> 1.119-7
- rebuild for new perl
@@ -77,8 +80,8 @@ Convert::BinHex extracts data from Macin
- assume rpm knows about %%check and %%{perl_vendorlib}
- cosmetic spec file changes
-* Fri Apr 7 2005 Michael Schwendt <mschwendt[AT]users.sf.net>
+* Fri Apr 7 2005 Michael Schwendt <mschwendt[AT]users.sf.net> 1.119-2
- rebuilt
-* Wed Sep 15 2004 Ville Skyttä <ville.skytta at iki.fi> - 0:1.119-1
-- First build.
+* Wed Sep 15 2004 Ville Skyttä <ville.skytta at iki.fi> 1.119-1
+- first build
14 years, 5 months
[Bug 552554] Merge Review: perl-Convert-BinHex - Macintosh BinHex extractor library for Perl
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552554
--- Comment #2 from Paul Howarth <paul(a)city-fan.org> 2010-01-14 15:37:38 EST ---
(In reply to comment #1)
> MUST items:
>
> [YES] rpmlint is silent:
>
> $ rpmlint ./perl-Convert-BinHex.spec
> perl-Convert-BinHex-1.119-11.fc13.noarch.rpm
> perl-Convert-BinHex-1.119-11.fc13.src.rpm
> 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
>
> [YES] Package meets naming and packaging guidelines.
> [YES] Spec file matches the base package name.
>
> [NOT SURE] Meets licensing guidelines.
> [NO] License specified in spec file and matches.
> - CPAN says: Unknown license
> - included COPYING contains text of GPLv1
> - spec file says: GPL+ or Artistic
lib/Convert/BinHex.pm (the actual code) says (near the end):
Copyright (c) 1997 by Eryq. All rights reserved. This program is free
software; you can redistribute it and/or modify it under the same terms as
Perl itself.
This makes it GPL+ or Artistic
> [YES] Spec file in American English.
> [YES] Spec file is legible.
>
> [NO] Spec file uses macros consistently.
> - %install section contains
> /usr/bin/find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
> while few lines above macro %{__rm} is used
Fixed
> - %{__chmod} -R u+w %{buildroot}/*
> might be replaced with
> %{_fixperms} %{buildroot}/*
Used %{_fixperms} %{buildroot}
Changes applied in CVS (1.119-12).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
14 years, 5 months
[Bug 552554] Merge Review: perl-Convert-BinHex - Macintosh BinHex extractor library for Perl
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552554
--- Comment #1 from Jan Vcelak <jvcelak(a)redhat.com> 2010-01-14 12:59:22 EST ---
MUST items:
[YES] rpmlint is silent:
$ rpmlint ./perl-Convert-BinHex.spec
perl-Convert-BinHex-1.119-11.fc13.noarch.rpm
perl-Convert-BinHex-1.119-11.fc13.src.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
[YES] Package meets naming and packaging guidelines.
[YES] Spec file matches the base package name.
[NOT SURE] Meets licensing guidelines.
[NO] License specified in spec file and matches.
- CPAN says: Unknown license
- included COPYING contains text of GPLv1
- spec file says: GPL+ or Artistic
[YES] Spec file in American English.
[YES] Spec file is legible.
[NO] Spec file uses macros consistently.
- %install section contains
/usr/bin/find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
while few lines above macro %{__rm} is used
- %{__chmod} -R u+w %{buildroot}/*
might be replaced with
%{_fixperms} %{buildroot}/*
[YES] Sources match upstream version.
[YES] Can be successfully compiled.
[YES] All BuildRequires are listed.
[YES] Doesn't bundle copies of system libraries.
[YES] Owns all it's files.
[YES] Directory ownership meets Perl packaging guidelines.
[YES] Permissions specified properly in %files.
[YES] Contains code, or permissible content.
[YES] Documentation needn't separate package.
[YES] %doc files doesn't affect runtime.
[YES] Cleans buildroot in %clean.
[YES] Cleans buildroot at the beginning of %install.
[YES] All filenames are valid UTF-8.
Other must items doesn't concern.
SHOULD items:
[YES] Builds in mock.
[YES] Builds on all supported architectures. (Package is architecture
independent.)
[YES] Sane scriptlets.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
14 years, 5 months
[Bug 555507] New: FTBFS perl-Module-Starter-Plugin-CGIApp-0.10-2.fc12
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: FTBFS perl-Module-Starter-Plugin-CGIApp-0.10-2.fc12
https://bugzilla.redhat.com/show_bug.cgi?id=555507
Summary: FTBFS perl-Module-Starter-Plugin-CGIApp-0.10-2.fc12
Product: Fedora
Version: rawhide
Platform: All
URL: http://linux.dell.com/files/fedora/FixBuildRequires/mo
ck-results/
OS/Version: Linux
Status: NEW
Keywords: Triaged
Severity: high
Priority: high
Component: perl-Module-Starter-Plugin-CGIApp
AssignedTo: emmanuel.seyman(a)club-internet.fr
ReportedBy: ftbfs(a)fedoraproject.org
QAContact: extras-qa(a)fedoraproject.org
CC: emmanuel.seyman(a)club-internet.fr,
fedora-perl-devel-list(a)redhat.com
Blocks: 538681
Classification: Fedora
perl-Module-Starter-Plugin-CGIApp-0.10-2.fc12.src.rpm Failed To Build From
Source against the rawhide tree. See http://fedoraproject.org/wiki/FTBFS for
more information.
If you believe this is actually a bug in another package, do NOT change the
component in this bug or close this bug. Instead, add the appropriate bug
number from the other package to the "Depends on" line in this bug. If the
other package does not yet have a bug created that you think matches, please
create one. Doing so helps us properly track bugs and their dependencies, just
as we track package dependencies. (If you close this bug, and the other
package is not fixed before the next FTBFS run, a new bug will get created.
Please follow the above advice to avoid such duplication.)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
14 years, 5 months
[Bug 555506] New: FTBFS perl-libintl-1.16-10.fc12
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: FTBFS perl-libintl-1.16-10.fc12
https://bugzilla.redhat.com/show_bug.cgi?id=555506
Summary: FTBFS perl-libintl-1.16-10.fc12
Product: Fedora
Version: rawhide
Platform: All
URL: http://linux.dell.com/files/fedora/FixBuildRequires/mo
ck-results/
OS/Version: Linux
Status: NEW
Keywords: Triaged
Severity: high
Priority: high
Component: perl-libintl
AssignedTo: matthias(a)rpmforge.net
ReportedBy: ftbfs(a)fedoraproject.org
QAContact: extras-qa(a)fedoraproject.org
CC: matthias(a)rpmforge.net,
fedora-perl-devel-list(a)redhat.com
Blocks: 538681
Classification: Fedora
perl-libintl-1.16-10.fc12.src.rpm Failed To Build From Source against the
rawhide tree. See http://fedoraproject.org/wiki/FTBFS for more information.
If you believe this is actually a bug in another package, do NOT change the
component in this bug or close this bug. Instead, add the appropriate bug
number from the other package to the "Depends on" line in this bug. If the
other package does not yet have a bug created that you think matches, please
create one. Doing so helps us properly track bugs and their dependencies, just
as we track package dependencies. (If you close this bug, and the other
package is not fixed before the next FTBFS run, a new bug will get created.
Please follow the above advice to avoid such duplication.)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
14 years, 5 months
[Bug 555505] New: FTBFS perl-ExtUtils-InferConfig-1.03-3.fc12
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: FTBFS perl-ExtUtils-InferConfig-1.03-3.fc12
https://bugzilla.redhat.com/show_bug.cgi?id=555505
Summary: FTBFS perl-ExtUtils-InferConfig-1.03-3.fc12
Product: Fedora
Version: rawhide
Platform: All
URL: http://linux.dell.com/files/fedora/FixBuildRequires/mo
ck-results/
OS/Version: Linux
Status: NEW
Keywords: Triaged
Severity: high
Priority: high
Component: perl-ExtUtils-InferConfig
AssignedTo: mmaslano(a)redhat.com
ReportedBy: ftbfs(a)fedoraproject.org
QAContact: extras-qa(a)fedoraproject.org
CC: fedora-perl-devel-list(a)redhat.com, mmaslano(a)redhat.com
Blocks: 538681
Classification: Fedora
perl-ExtUtils-InferConfig-1.03-3.fc12.src.rpm Failed To Build From Source
against the rawhide tree. See http://fedoraproject.org/wiki/FTBFS for more
information.
If you believe this is actually a bug in another package, do NOT change the
component in this bug or close this bug. Instead, add the appropriate bug
number from the other package to the "Depends on" line in this bug. If the
other package does not yet have a bug created that you think matches, please
create one. Doing so helps us properly track bugs and their dependencies, just
as we track package dependencies. (If you close this bug, and the other
package is not fixed before the next FTBFS run, a new bug will get created.
Please follow the above advice to avoid such duplication.)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
14 years, 5 months