On Fri, Mar 25, 2011 at 02:36:59PM +0100, Tomas Mraz wrote:
On Tue, 2011-03-22 at 13:13 +0300, Dmitry V. Levin wrote:
> On Tue, Mar 22, 2011 at 10:31:25AM +0100, Tomas Mraz wrote:
> > On Tue, 2011-03-22 at 12:00 +0300, Dmitry V. Levin wrote:
> [...]
> > > - cleanup trailing whitespaces and indentation that uses spaces before
> > > tabs as reported by
> > > git diff --check 4b825dc642cb6eb9a060e54bf8d69288fbee4904 HEAD
> > > - adjust hooks/update to reject new commits introducing new trailing
> > > whitespaces;
> [...]
> > I agree with all the points above except the cleanup of trailing
> > whitespaces and indentation. What is the advantage of having it done in
> > one commit as opposed to fixing it only at places where the code is
> > touched by other changes during regular bugfix/enhancement patching?
> I see several advantages:
> - easier to follow one change per commit principle;
> - no need to bother about spacing issues when moving code around;
> - implementation in hooks/update would be as simple and reliable as the
> "git diff" command mentioned above.
OK, if other developers agree I will not block this cleanup patch.
I agree with the cleanup; that's definitely the sort of thing that's best to
do all at once, and the moment *before* we start using DVCS in force is a
good moment to have it done.
In fact, I would ask whether we should be enforcing coding standards
(indentation, spacing, etc) at the same time.
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer
http://www.debian.org/
slangasek(a)ubuntu.com vorlon(a)debian.org