On Tue, 2011-11-01 at 04:22 +0400, Dmitry V. Levin wrote:
On Sun, Mar 27, 2011 at 12:11:32AM +0300, Dmitry V. Levin wrote:
> On Fri, Mar 25, 2011 at 02:38:10PM +0100, Tomas Mraz wrote:
> > On Tue, 2011-03-22 at 12:00 +0300, Dmitry V. Levin wrote:
> > > Based on my experience of earlier cvs->git migrations, there are few
> > > things that could be done naturally now:
> > >
> > > - migrate from .cvsignore to .gitignore;
> > > - cleanup trailing whitespaces and indentation that uses spaces before
> > > tabs as reported by
> > > git diff --check 4b825dc642cb6eb9a060e54bf8d69288fbee4904 HEAD
> > > - adjust hooks/update to reject new commits introducing new trailing
> > > whitespaces;
> > > - accept a guideline about git commit messages style and maintaining
> > > ChangeLog file in git; I propose to deprecate the ChangeLog file in
> > > the repository, follow to commit log requirements (e.g. based on
> > > "Commit log requirements" described in
> > >
http://git.savannah.gnu.org/cgit/coreutils.git/tree/HACKING), and
> > > use the gitlog-to-changelog tool to generate the ChangeLog file from
> > > git log at "make dist" time.
> > >
> > > I made these changes in strace project after cvs->git migration in
> > > July of 2009, and everybody seems to be happy so far.
> >
> > Will you proceed with the changes you proposed, Dmitry?
>
> Yes, I hope to find time and prepare these changes tomorrow.
Unfortunately, I failed to implement this plan in time, but anyway,
better late than never. I've contacted #fedora-admin and submitted a
fedora-infrastructure ticket as result of the discussion
(
https://fedorahosted.org/fedora-infrastructure/ticket/2996)
While fedorahosted admins are implementing this trivial request, I've
prepared the changes mentioned in the plan, and several build fixes
on top of them:
http://git.altlinux.org/people/ldv/packages/?p=linux-pam.git;a=shortlog;h...
Fix whitespace issues
Rename all .cvsignore files to .gitignore
Remove modules/pam_timestamp/hmacfile from distribution
Fix "make distcheck"
Generate ChangeLog from git log
Create release tarballs using safe ownership and permissions
Remove generated files
Move generated auxiliary files to build-aux directory
Update .gitignore files
Fix usage of LIBADD, LDADD and LDFLAGS
Use libpam.la/libpam_misc.la to link with -lpam/-lpam_misc
With these patches applied, linux-pam passes
$ ./autogen.sh && ./configure && make distcheck
invoked from a clean checkout.
Please review.
I've reviewed the patches and they seem to be OK. (I did not test them
though.) Please commit them.
--
Tomas Mraz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb