[linux-pam] #4: [PATCH] po/ja.po: Fix some wrong translations and so on
by fedora-badges
#4: [PATCH] po/ja.po: Fix some wrong translations and so on
--------------------+-------------------------------------------------------
Reporter: fumiyas | Owner: pam-developers(a)lists.fedorahosted.org
Type: defect | Status: new
Priority: major | Component: library
Version: 1.1.x | Keywords: l10n
--------------------+-------------------------------------------------------
I've updated po/ja.po to fix some wrong translations and so on.
Please see and commit the attached patch to master repository if you feel
good.
Should I contact the original translator (Kiyoto Hashida
<khashida(a)redhat.com>) to check and confirm this patch?
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/4>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
8 years, 11 months
[linux-pam] #20: compilation warnings
by fedora-badges
#20: compilation warnings
---------------------+------------------------------
Reporter: mirraz | Owner: pam-developers@…
Type: defect | Status: new
Priority: minor | Component: library
Version: | Keywords:
Blocked By: | Blocking:
---------------------+------------------------------
Building pam-1.1.6 I'v got this compilation warnings:
{{{
md5.c:145:2: warning: dereferencing type-punned pointer will break strict-
aliasing rules [-Wstrict-aliasing]
md5.c:146:2: warning: dereferencing type-punned pointer will break strict-
aliasing rules [-Wstrict-aliasing]
misc_conv.c:213:22: warning: the address of ‘line’ will always evaluate as
‘true’ [-Waddress]
misc_conv.c:325:15: warning: the address of ‘binary_prompt’ will always
evaluate as ‘true’ [-Waddress]
}}}
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/20>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
9 years, 1 month
[linux-pam] #9: Allow pam_lastlog to write to utmp as an option
by fedora-badges
#9: Allow pam_lastlog to write to utmp as an option
-------------------------+-------------------------------------------------
Reporter: | Owner: pam-developers@…
shadowkyogre | Status: new
Type: | Component: modules
enhancement | Keywords: pam_lastlog utmp update patch
Priority: major | prototype
Version: 1.1.x | Blocking:
Blocked By: |
-------------------------+-------------------------------------------------
The following patch for pam_lastlog allows it to write to utmp as well as
wtmp. Part of the code is from xorg-sessreg to help make a utmp entry. I
only tested this on my desktop, which is running Arch Linux, so some
modifications may need to be made in order to make it more portable.
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/9>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
9 years, 1 month
[linux-pam] #5: multiple pam_namespace unmount problems
by fedora-badges
#5: multiple pam_namespace unmount problems
-----------------------------+------------------------------
Reporter: andersblomdell | Owner: pam-developers@…
Type: defect | Status: new
Priority: major | Component: library
Version: 1.1.x | Keywords:
Blocked By: | Blocking:
-----------------------------+------------------------------
This is essentially a short version of the bug in:
http://bugzilla.redhat.com/show_bug.cgi?id=755216
Essentially pam_namespace (1.1.5) suffers the following problems:
1. The (bind) mounts done in the new namespace is visible in the
original namespace (Error "too many levels of symbolic links").
2. At pam_namespace exit, the original mounting is restored for any
remaining child processes (daemons), which is a security problem.
Patch is attached
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/5>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
10 years, 3 months
[linux-pam] #19: logger message uses uninitialized char buffer in group_match() of pam_access.c
by fedora-badges
#19: logger message uses uninitialized char buffer in group_match() of
pam_access.c
-----------------------+------------------------------
Reporter: nickfelt | Owner: pam-developers@…
Type: defect | Status: new
Priority: minor | Component: modules
Version: 1.1.x | Keywords:
Blocked By: | Blocking:
-----------------------+------------------------------
I was debugging my configuration of the pam_access module and noticed some
strange behavior in the debug-level logging messages, which I traced to
the `group_match()` function:
[https://git.fedorahosted.org/cgit/linux-
pam.git/tree/modules/pam_access/pam_access.c#n566]
On line 576 it writes a log message using the `grptok` char buffer, which
has just been declared and not initialized. Presumably the logging call
should either use `tok` instead to print the group name in parentheses, or
the logging call should be moved below the `strncpy()` call, at which
point `grptok` is valid, to print the group name without parentheses. I
would've attached a patch but I wasn't sure which solution was preferable.
At least on my machine, the current code prints an empty string on the
first call to `group_match` and then on each successive call it prints the
value of grptok corresponding to the previous call to `group_match` that
is still in the buffer. I've attached my test-case
`/etc/security/access.conf` and the logging output I saw.
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/19>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
10 years, 3 months
[linux-pam] #18: pam_unix.so segfaults when SHA_CRYPT_*_ROUNDS is set
by fedora-badges
#18: pam_unix.so segfaults when SHA_CRYPT_*_ROUNDS is set
---------------------+------------------------------
Reporter: mgorny | Owner: pam-developers@…
Type: defect | Status: new
Priority: major | Component: modules
Version: | Keywords:
Blocked By: | Blocking:
---------------------+------------------------------
Gentoo bug report: https://bugs.gentoo.org/show_bug.cgi?id=484732
pam_unix_acct.c:200 calls:
{{{
ctrl = _set_ctrl(pamh, flags, NULL, NULL, NULL, argc, argv);
}}}
while `_set_ctrl()` writes to `*rounds` unconditionally to whether it is
provided or NULL:
{{{
if (on(UNIX_SHA256_PASS, ctrl) || on(UNIX_SHA512_PASS, ctrl)) {
val=search_key ("SHA_CRYPT_MAX_ROUNDS", LOGIN_DEFS);
if (val) {
*rounds = strtol(val, NULL, 10);
free (val);
}
}
}}}
This is a regression since 1.1.6. Also, it makes it impossible to login to
the system or e.g. `su`.
I don't know what the preferred fix would be. You could either check for
non-NULL `rounds` or require that `_set_ctrl()` is called with non-NULL
`rounds`.
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/18>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
10 years, 7 months
Current open bugreports, what to do with them?
by Thorsten Kukuk
Hi,
the following tickets are currently open in the bug tracking system:
#2: I would propose to close that as will not be changed.
It's not a defect.
#4: ja.po, Tomas, you did update the translations in the past.
Either we take it or we should reject it.
#14: Same as #4, only for dutch
#5: The available patches contains races and a kernel modification.
What should we do with that patch? Reject?
#7: I don't like that patch and the idea, what should we do with
this?
#8: I like the idea, I will look at the patches
#9: The patch is broken, and I don't like the change of the
default behavior, now writing utmp if not specified otherwise.
And I don't understand why it is necessary. Should we reject this?
Thorsten
--
Thorsten Kukuk, Senior Architect SLES & Common Code Base
SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
10 years, 7 months
[PATCH] po/Makefile.in.in: Use MKDIR_P instead of mkdir_p
by Gustavo Zacarias
$(mkdir_p) is deprecated in newer automake versions causing install
failures when recreating configure.
Signed-off-by: Gustavo Zacarias <gustavo(a)zacarias.com.ar>
---
po/Makefile.in.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/po/Makefile.in.in b/po/Makefile.in.in
index 2ed49e6..098e15b 100644
--- a/po/Makefile.in.in
+++ b/po/Makefile.in.in
@@ -31,7 +31,7 @@ gettextsrcdir = $(datadir)/gettext/po
INSTALL = @INSTALL@
INSTALL_DATA = @INSTALL_DATA@
mkinstalldirs = $(SHELL) @install_sh@ -d
-mkdir_p = @mkdir_p@
+mkdir_p = @MKDIR_P@
GMSGFMT_ = @GMSGFMT@
GMSGFMT_no = @GMSGFMT@
--
1.8.1.5
10 years, 7 months