Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=717966

--- Comment #1 from Chris Lalancette clalance@redhat.com 2011-07-05 14:47:26 EDT --- We are still sorting out the license a bit with upstream. The problem is that the upstream sources are GPLv3, but the program that wants to use them (imagefactory) is GPLv2. We are discussing the best path forward with upstream, and I'll update the package once we have sorted it out.

Chris Lalancette

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=717966

Mark McLoughlin markmc@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |markmc@redhat.com AssignedTo|nobody@fedoraproject.org |markmc@redhat.com Flag| |fedora-review?

--- Comment #3 from Mark McLoughlin markmc@redhat.com 2011-07-12 09:12:33 EDT --- Okay, first up ... rpmlint output:

python-psphere.spec: W: invalid-url Source0: http://bitbucket.org/jkinred/psphere/get/python-psphere-0.1.tar.gz HTTP Error 500: Internal Server Error 0 packages and 1 specfiles checked; 0 errors, 1 warnings.

python-psphere.noarch: W: spelling-error Summary(en_US) vSphere -> v Sphere, sphere, spherule python-psphere.noarch: W: summary-not-capitalized C vSphere SDK for Python python-psphere.noarch: W: spelling-error %description -l en_US vSphere -> v Sphere, sphere, spherule python-psphere.noarch: W: no-documentation python-psphere.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/psphere/scripting.py 0644L /usr/bin/env 1 packages and 0 specfiles checked; 1 errors, 4 warnings.

What I think needs fixing:

- There is no 0.1 release of psphere yet, so we should either wait for a release or (uggh) get into:

http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease

- We need either a URL for the tarball created by upstream, or no URL at all and instructions on how to regenerate the tarball from a tag. See:

http://fedoraproject.org/wiki/Packaging:SourceURL#Referencing_Source

- The non-executable-script error can be fixed using a variant of:

http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_li...

What can be ignored:

- Spelling warnings about vSphere, it's correct

- no-documentation warning - none is included in the tarball

- The licensing change; no need to wait for that, GPLv3 is perfectly fine for inclusion into Fedora

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=717966

--- Comment #5 from Mark McLoughlin markmc@redhat.com 2011-07-12 09:17:41 EDT --- Created attachment 512426 --> https://bugzilla.redhat.com/attachment.cgi?id=512426 new spec

Here's a new spec with all the comments above resolved if you want to use it

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=717966

--- Comment #7 from Chris Lalancette clalance@redhat.com 2011-07-12 09:54:03 EDT --- Thanks for the review, Mark.

(In reply to comment #3)

Okay, first up ... rpmlint output:

python-psphere.spec: W: invalid-url Source0: http://bitbucket.org/jkinred/psphere/get/python-psphere-0.1.tar.gz HTTP Error 500: Internal Server Error 0 packages and 1 specfiles checked; 0 errors, 1 warnings.

python-psphere.noarch: W: spelling-error Summary(en_US) vSphere -> v Sphere, sphere, spherule python-psphere.noarch: W: summary-not-capitalized C vSphere SDK for Python python-psphere.noarch: W: spelling-error %description -l en_US vSphere -> v Sphere, sphere, spherule python-psphere.noarch: W: no-documentation python-psphere.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/psphere/scripting.py 0644L /usr/bin/env 1 packages and 0 specfiles checked; 1 errors, 4 warnings.

What I think needs fixing:

• There is no 0.1 release of psphere yet, so we should either wait for a release or (uggh) get into:

http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease

This is the nastiest one here. When you run "python setup.py sdist" on the hg sources, you get a tarball out that is named "psphere-0.1.tar.gz". Given the "Referencing_Source" link below, I feel like we should stick with that version number, even though there is no official upstream release.

• We need either a URL for the tarball created by upstream, or no URL at all and instructions on how to regenerate the tarball from a tag. See:

  http://fedoraproject.org/wiki/Packaging:SourceURL#Referencing_Source

Right, fixed this up according to the link above.

• The non-executable-script error can be fixed using a variant of:

http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_li...

Stolen from your example SPEC, and fixed.

What can be ignored:

• Spelling warnings about vSphere, it's correct

• no-documentation warning - none is included in the tarball

• The licensing change; no need to wait for that, GPLv3 is perfectly fine for inclusion into Fedora

(In reply to comment #4)

Okay, some more comments:

• no need for the BuildRoot tag anymore http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

Removed.

• no need for %clean section anymore http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

Removed.

• the description should be longer and end with a period. Can just take the "Welcome" text from the website

Fixed.

• the -n argument to %setup is redundant; you're using the default value

Fixed.

• no need for Prefix tag

Removed.

• we should own the /usr/lib/python2.7/site-packages/psphere/ directory

Fixed.

• recommendation is to avoid using INSTALLED_FILES http://fedoraproject.org/wiki/Packaging:Python#Byte_compiling http://fedoraproject.org/wiki/Packaging:Python_Eggs

Fixed.

• use the %{__python} macro

Fixed.

• URL: instead of Url:

Fixed.

• should pass --skip-build argument to setuptools install

Fixed.

• I'd avoid the optimize argument to setuptools install, no reason to override the default

Fixed.

I've uploaded a new SPEC: http://people.redhat.com/clalance/python-psphere/python-psphere.spec and new SRPM: http://people.redhat.com/clalance/python-psphere/python-psphere-0.1-4.fc14.s...

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=717966

--- Comment #9 from Mark McLoughlin markmc@redhat.com 2011-07-12 13:03:07 EDT --- (In reply to comment #7)

(In reply to comment #3)

...

• There is no 0.1 release of psphere yet, so we should either wait for a release or (uggh) get into:

http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease

This is the nastiest one here. When you run "python setup.py sdist" on the hg sources, you get a tarball out that is named "psphere-0.1.tar.gz". Given the "Referencing_Source" link below, I feel like we should stick with that version number, even though there is no official upstream release.

Nope, that doesn't cut it - upstream could release 0.1 some time in the future with newer code

0.1 as a version number is meaningless right now - it doesn't refer to a specific version of the code

It sounds like you're in good contact with upstream - how about suggesting a release? That might be the simplest way of resolving it?

Otherwise, it should be python-vsphere-0.1-0.1.42accc3ffe67hg

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=717966

Chris Lalancette clalance@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |721144

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=717966

Mark McLoughlin markmc@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|markmc@redhat.com |clalance@redhat.com Flag|fedora-review? |fedora-review+

--- Comment #12 from Mark McLoughlin markmc@redhat.com 2011-07-14 12:56:36 EDT --- Awesome, looks perfect now!

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=717966

Chris Lalancette clalance@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #14 from Chris Lalancette clalance@redhat.com 2011-07-14 13:09:15 EDT --- New Package SCM Request ======================= Package Name: python-psphere Short Description: vSphere SDK for Python Owners: clalance

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=717966

Chris Lalancette clalance@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE Last Closed| |2011-07-27 05:34:46

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=717966

--- Comment #17 from Jon Ciesla limb@jcomserv.net 2011-09-24 11:28:15 EDT --- Git done (by process-git-requests).

https://bugzilla.redhat.com/show_bug.cgi?id=717966

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+