Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717966
--- Comment #4 from Mark McLoughlin <markmc(a)redhat.com> 2011-07-12 09:15:01 EDT ---
Okay, some more comments:
- no need for the BuildRoot tag anymore
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
- no need for %clean section anymore
http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
- the description should be longer and end with a period. Can just take
the "Welcome" text from the website
- the -n argument to %setup is redundant; you're using the default value
- no need for Prefix tag
- we should own the /usr/lib/python2.7/site-packages/psphere/ directory
- recommendation is to avoid using INSTALLED_FILES
http://fedoraproject.org/wiki/Packaging:Python#Byte_compiling
http://fedoraproject.org/wiki/Packaging:Python_Eggs
- use the %{__python} macro
- URL: instead of Url:
- should pass --skip-build argument to setuptools install
- I'd avoid the optimize argument to setuptools install, no reason to
override the default
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.