Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717966
Mark McLoughlin markmc@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |markmc@redhat.com AssignedTo|nobody@fedoraproject.org |markmc@redhat.com Flag| |fedora-review?
--- Comment #3 from Mark McLoughlin markmc@redhat.com 2011-07-12 09:12:33 EDT --- Okay, first up ... rpmlint output:
python-psphere.spec: W: invalid-url Source0: http://bitbucket.org/jkinred/psphere/get/python-psphere-0.1.tar.gz HTTP Error 500: Internal Server Error 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
python-psphere.noarch: W: spelling-error Summary(en_US) vSphere -> v Sphere, sphere, spherule python-psphere.noarch: W: summary-not-capitalized C vSphere SDK for Python python-psphere.noarch: W: spelling-error %description -l en_US vSphere -> v Sphere, sphere, spherule python-psphere.noarch: W: no-documentation python-psphere.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/psphere/scripting.py 0644L /usr/bin/env 1 packages and 0 specfiles checked; 1 errors, 4 warnings.
What I think needs fixing:
- There is no 0.1 release of psphere yet, so we should either wait for a release or (uggh) get into:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease
- We need either a URL for the tarball created by upstream, or no URL at all and instructions on how to regenerate the tarball from a tag. See:
http://fedoraproject.org/wiki/Packaging:SourceURL#Referencing_Source
- The non-executable-script error can be fixed using a variant of:
http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_li...
What can be ignored:
- Spelling warnings about vSphere, it's correct
- no-documentation warning - none is included in the tarball
- The licensing change; no need to wait for that, GPLv3 is perfectly fine for inclusion into Fedora