Using the uiautomation.spec as the example since that had the newest
change
time according to svn.
For purely managed code currently, due entirely to stupidity on the part of
the Mono packaging guidelines, currently you need to add:
%define debug_package %{nil}
Or you will end up with an empty debug package, It is prefered to be at the
very first line of the spec file.
ok, I added this to all of them except uiaatkbridge because it does
have a c library in it
Source: needs to be a full valid URL (for something like codeplex where
direct downloading isn't possible because of clickthrough licenses add a
comment). E.g.
Source0:
http://banshee-project.org/files/banshee/banshee-1-%{version}.tar.bz2
I added this to all of them except uiadbuscorebridge since that hasn't
officially been released
Your buildroot isn't unique and thus can cause problems, the
prefered
standard is:
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
I updated this in all of them. With openSUSE they generate fresh
jails on top of xen on the fly for everybuild so thi build root really
doesn't matter. That is why they were really simple
Group is 2 steps deep:
Invalid:
Group: Development/Languages/Mono
Valid:
Group: Development/Libraries
Updated
Your use of the license tag is invalid:
Invalid:
License: MIT/X11
Valid:
License: MIT
should I add another line in there for X11 or is MIT good enough?
If you fail using parallel make:
make %{?_smp_mflags}
then you need to add a comment referencing the filed bug documenting.
I've added this, but had previously left it out since there really
isn't much to build in these packages. They all tend to build within
a few minutes
%install needs to start by cleaning up, e.g.
%install
rm -rf %{buildroot}
Added.
Also please keep package descriptions at the top of the spec and
have
separate %files entries at the buttom, mixing them is bad style.
Fixed.
You should probably also work on the description, it can stand to be
a
little bit cleaner and possibly lose the coding jargon. Remember this is
what users see, something along the lines of:
"User Interface Automation (UIA) is an advanced accessibility framework for
use with Mono".
Maybe fixed :)
You should also avoid the "politics" in descriptions:
The Mono Project is an open development initiative that is working to
develop an open source, Unix version of the .NET development platform.
Its objective is to enable Unix developers to build and deploy
cross-platform .NET applications. The project will implement various
technologies that have been submitted to the ECMA for standardization.
That was just something I pulled from the upstream package... removed.
Parts of winfx
Maybe could be:
"User Interface Automation (UIA) WinFX components for use with Mono"
Changed.
Finally in the changelog please append the release:
Bad:
* Thu Apr 30 2009 Stephen Shaw <sshaw(a)decriptor.com> - 1.0
Good:
* Thu Apr 30 2009 Stephen Shaw <sshaw(a)decriptor.com> - 1.0-1
This lets us see what happened at specific releases.
updated.
Aside that you look good, once these are fixed I will attempt a mock
build
and see if that and rpmlint will throw up any dirt.
- David
Thanks,
Stephen
http://anonsvn.mono-project.com/viewvc/trunk/uia2atk/build/specs/fedora/