On Wed, May 15, 2019 at 01:43:44PM +0200, csfakian(a)redhat.com wrote:
From: Christos Sfakianakis <csfakian(a)redhat.com>
Hi,
after pulling numerous updates from upstream (with regards to the last time
of testing) and re-testing already ported recipes of phase1/2, I encountered
Netlink related errors when trying to modify a vlan device after its creation
(in this case MTU). I tested the same modification with all other devices used
in the recipes and there were no errors thrown.
In effect, for commands like:
host1.br0.mtu = 1500 --> Bridge
host1.eth0.mtu = 1500 --> Eth
host1.vlan0.mtu = 1500 --> Vlan
which are translated into the corresponding 'set' messages:
{'IFLA_LINKINFO': {'attrs': [('IFLA_INFO_KIND',
'bond')]}, 'IFLA_MTU': 1500}
{'IFLA_MTU': 1500}
{'IFLA_LINKINFO': {'attrs': [('IFLA_INFO_KIND',
'vlan')]}, 'IFLA_MTU': 1500}
the first 2 are accepted as expected, but the latter is not.
Therefore, I chose to embed the MTU settings for vlans in the
constructors, which tranlates to a single nl 'add' command instead of an
'add' followed by a 'set'. This seems to work without issues.
Semantically, the recipes remain the same.
Christos
Christos Sfakianakis (1):
lnst.Recipes.ENRT: edit vlan creation in the recipes
.../VirtualBridgeVlanInGuestMirroredRecipe.py | 23 +++++----
.../ENRT/VirtualBridgeVlanInGuestRecipe.py | 21 ++++----
.../VirtualBridgeVlanInHostMirroredRecipe.py | 21 ++++----
.../ENRT/VirtualBridgeVlanInHostRecipe.py | 20 ++++----
.../ENRT/VirtualBridgeVlansOverBondRecipe.py | 48 +++++++++----------
...rtualOvsBridgeVlanInGuestMirroredRecipe.py | 23 +++++----
.../ENRT/VirtualOvsBridgeVlanInGuestRecipe.py | 23 +++++----
...irtualOvsBridgeVlanInHostMirroredRecipe.py | 2 +-
.../ENRT/VirtualOvsBridgeVlanInHostRecipe.py | 19 ++++----
.../VirtualOvsBridgeVlansOverBondRecipe.py | 2 +-
lnst/Recipes/ENRT/VlansOverBondRecipe.py | 27 ++++++-----
lnst/Recipes/ENRT/VlansOverTeamRecipe.py | 26 +++++-----
lnst/Recipes/ENRT/VlansRecipe.py | 29 ++++++-----
13 files changed, 156 insertions(+), 128 deletions(-)
--
2.17.1
_______________________________________________
LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
Fedora Code of Conduct:
https://getfedora.org/code-of-conduct.html
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/lnst-developers@lists.fedora...
this looks ok, pushed, thanks.
-Ondrej