[lnst trac] #54: Documentation: clean up LnstIntro
by fedora-badges
#54: Documentation: clean up LnstIntro
----------------------+------------------------------------------
Reporter: olichtne | Owner:
Type: task | Status: new
Priority: major | Milestone: Complete Wiki Documentation
Component: wiki | Version:
Keywords: | Blocked By:
Blocking: |
----------------------+------------------------------------------
The document is a little bit outdated. It contains a lot of information
because when it was created the wiki didn't exist.
First we want to move the first part to be a separate page. This contains
information about the project and the community. The new page should
either be the front-page or an About page where the user goes first.
Then we need to clean up the entire document so that it doesn't contain
redundant information that will be located in other documents created in
this milestone.
--
Ticket URL: <https://fedorahosted.org/lnst/ticket/54>
lnst <https://fedorahosted.org/lnst/>
Linux Network Stack Test
10 years, 3 months
[lnst trac] #53: Documentation: using 3rd party test tools
by fedora-badges
#53: Documentation: using 3rd party test tools
----------------------+------------------------------------------
Reporter: olichtne | Owner:
Type: task | Status: new
Priority: major | Milestone: Complete Wiki Documentation
Component: wiki | Version:
Keywords: | Blocked By:
Blocking: |
----------------------+------------------------------------------
This is a new feature that was implemented recently. You can now use any
number of test tools, and all you need to do is place them in the correct
directory.
This is an advanced topic so the article should be located accordingly.
Documentation should contain information about where and in what format
you need to put the tools. How they are transferred to the slave machines.
And how to use them from the recipe.
--
Ticket URL: <https://fedorahosted.org/lnst/ticket/53>
lnst <https://fedorahosted.org/lnst/>
Linux Network Stack Test
10 years, 3 months
[lnst trac] #50: Wiki article: How to Structure LNST Recipes
by fedora-badges
#50: Wiki article: How to Structure LNST Recipes
----------------------+------------------------------------------
Reporter: rpazdera | Owner:
Type: task | Status: new
Priority: major | Milestone: Complete Wiki Documentation
Component: wiki | Version:
Keywords: | Blocked By:
Blocking: |
----------------------+------------------------------------------
This article should cover everything about lnst recipe creation from a
point of view of an inexperienced LNST user.
It should be easy to understand and not too technical. It doesn't have to
cover the topic completely, but it should give enough information for a
newcomer.
This article should incorporate the topic in the 4th section of the LNST
Intro document.
--
Ticket URL: <https://fedorahosted.org/lnst/ticket/50>
lnst <https://fedorahosted.org/lnst/>
Linux Network Stack Test
10 years, 3 months
[lnst trac] #52: Wiki article: Machine Config XML Reference
by fedora-badges
#52: Wiki article: Machine Config XML Reference
----------------------+------------------------------------------
Reporter: rpazdera | Owner:
Type: task | Status: new
Priority: major | Milestone: Complete Wiki Documentation
Component: wiki | Version:
Keywords: | Blocked By:
Blocking: |
----------------------+------------------------------------------
There should be a separate reference for the XML format of machine configs
that belong to a pool directory. It should be a brief enumeration of
values for advanced users (the guide for beginners will be placed
separately).
--
Ticket URL: <https://fedorahosted.org/lnst/ticket/52>
lnst <https://fedorahosted.org/lnst/>
Linux Network Stack Test
10 years, 3 months
[lnst] Add attribute to explicitly disable cleanup on slave
by Jiří Pírko
commit 1bd7da4a1455697291cee12f4d0bfb89fbad81ef
Author: Jan Tluka <jtluka(a)redhat.com>
Date: Wed Dec 19 13:50:14 2012 +0100
Add attribute to explicitly disable cleanup on slave
This patch adds "skip_cleanup" attribute to the machineconfig's info tag.
If set to "1" or "true" the slave machine's preparation cleanup phase is
skipped and overrides the cleanup (-c) controller option.
Without this attribute it's impossible to run the controller and slave
instances on the same machine with virtual guests or 8021q/bonding/team
driver involved because the cleanup phase removes these network modules
before test execution and breaks the controller's network configuration.
Signed-off-by: Jan Tluka <jtluka(a)redhat.com>
lnst/Controller/NetTestController.py | 4 +++-
lnst/Controller/NetTestParse.py | 6 ++++++
2 files changed, 9 insertions(+), 1 deletions(-)
---
diff --git a/lnst/Controller/NetTestController.py b/lnst/Controller/NetTestController.py
index d673822..042d197 100644
--- a/lnst/Controller/NetTestController.py
+++ b/lnst/Controller/NetTestController.py
@@ -254,8 +254,10 @@ class NetTestController:
self._rpc_call(machine_id, "clear_resource_table")
required = self._resource_table
- if self._docleanup:
+ if self._docleanup and not info["skip_cleanup"]:
self._rpc_call(machine_id, 'machine_cleanup')
+ else:
+ logging.info("Skipping cleanup on machine %s" % machine_id)
for res_type, resources in self._resource_table.iteritems():
for res_name, res in resources.iteritems():
diff --git a/lnst/Controller/NetTestParse.py b/lnst/Controller/NetTestParse.py
index 3a24faf..28fe9ed 100644
--- a/lnst/Controller/NetTestParse.py
+++ b/lnst/Controller/NetTestParse.py
@@ -288,6 +288,12 @@ class MachineConfigParse(RecipeParser):
if self._has_attribute(node, "rpcport"):
info["rpcport"] = self._get_attribute(node, "rpcport", int)
+ if self._has_attribute(node, "skip_cleanup"):
+ info["skip_cleanup"] = self._get_attribute(node,
+ "skip_cleanup", bool_it)
+ else:
+ info["skip_cleanup"] = False
+
info["system_config"] = {}
try:
10 years, 11 months
Re: [lnst trac] #40: Doc: Recipe XML Format Reference on Wiki
by fedora-badges
#40: Doc: Recipe XML Format Reference on Wiki
-----------------------+-----------------------------------------
Reporter: rpazdera | Owner: rpazdera
Type: task | Status: new
Priority: major | Milestone: Complete Wiki Documentation
Component: wiki | Version:
Resolution: | Keywords:
Blocked By: | Blocking:
-----------------------+-----------------------------------------
Comment (by rpazdera):
Replying to [comment:5 jtluka]:
> Replying to [comment:4 rpazdera]:
> > I just finished writing this. It is available on wiki:
> >
> >
https://fedorahosted.org/lnst/wiki/Documentation/RecipeXMLFormatReference
> >
> > It grew a lot :-/. I tried to make it a bit easier to read by adding
a custom generated LNST Recipe XML map. It serves as a kind of click-
through index for quick access to individual tags within the manual.
>
> I really like it, the map is very easy to read, great work! I've read
through the document and it seems to me quite clear.
>
> I have only one suggestion for enhancement. The tag's description tables
under 2.3 MachineRequires and 2.3 NetConfig chapter looks a bit messy. I
propose to at least add a tag title before any tag's description table
under machinerequires/netconfig tag, for example something similar to
"Slaves","Options","Bonding example" titles under 2.3.2 Bonding.
Thanks for the feedback! You are right. That particular section is quite
crammed (that is why I
decided to make the map). I'll see what I can do :).
--
Ticket URL: <https://fedorahosted.org/lnst/ticket/40#comment:6>
lnst <https://fedorahosted.org/lnst/>
Linux Network Stack Test
10 years, 11 months
Re: [lnst trac] #31: quick guides
by fedora-badges
#31: quick guides
---------------------+------------------------------------------------
Reporter: jtluka | Owner: somebody
Type: task | Status: new
Priority: major | Milestone: Push LNST as a package into Fedora
Component: wiki | Version:
Resolution: | Keywords:
Blocked By: | Blocking:
---------------------+------------------------------------------------
Comment (by rpazdera):
Replying to [comment:3 jtluka]:
> Replying to [comment:2 rpazdera]:
> > We now have three quick guides. I was thinking do we want more of
them? Are there any more topics that could be explained effectively in
this practical form?
> >
> > Maybe we could do one for each command class, but I am not sure it
would be appropriate to demonstrate system_config with a whole recipe,
that is practically unrelated to it ...
>
> The initial idea behind the quick guides was to have a sample recipe in
the guide that's ready to use without any modification or with a minor
changes.
>
> For the command classes - I think this is better to have in separate
documentation. I'm also thinking that we should create some FAQ section,
answering can-lnst-do-this-and-that? with limitations, advices and so on.
Ok, in that case, 3 are maybe enough - at first you try one or two quick
guides and then you can refer to the standard docs. We can put up links to
them to the intro so the newcomers can get to them right away.
The FAQ section is a great idea! I'll setup a dummy link on the home page
for it.
--
Ticket URL: <https://fedorahosted.org/lnst/ticket/31#comment:4>
lnst <https://fedorahosted.org/lnst/>
Linux Network Stack Test
10 years, 11 months
Rethinking the <info> tag
by Radek Pazdera
Hello!
It occured to me, while I was writing the XML Reference, that we have
forgotten to consider expansion of information using which we would
like to match machines.
At the moment, LNST can match interfaces (that is pretty good) and apart
from that it can match hostnames and libvirt_domain from the info tag.
<info hostname="karel.org"/>
We agreed in the past, that we'd like to add more options to match to
that list. At first, we could just add more attributes to the <info> tag,
but after while it could get pretty messy (if we combine OS options,
hardware requirements, package requirements and all other sorts of
things into a single info tag). One tag in my opinion does not scale
very well.
I think we could (with a little effort) improve the scalability of
the solution for the future by making the info tag just a parent to
many more information tags. For instance:
<info>
<connection hostname="karel.org"/>
<libvirt domain="virtual_karel"/>
<os name="RHEL" version="4.9.z"/>
<pool name="Boston"/> <!-- use only a specific pool -->
</info>
A fairly short and general piece of code could be written to accept all
different subtags and parse it into:
recipe["machines"]["karel"]["info]["connection"]["hostname"]
recipe["machines"]["karel"]["info]["libvirt"]["domain"]
recipe["machines"]["karel"]["info]["os"]["name"]
recipe["machines"]["karel"]["info]["os"]["version"]
And we wouldn't have to worry about it at all (even if we would like to
add a new matching feature support). The users would add these tags into
their pool and into their recipes. The same parser would be used for both
and then we'd just compare strings in arrays.
What do you think?
Merry Christmas!
Radek
10 years, 11 months
[lnst trac] #51: Documentation: Create your own recipe
by fedora-badges
#51: Documentation: Create your own recipe
----------------------+------------------------------------------
Reporter: olichtne | Owner:
Type: task | Status: new
Priority: major | Milestone: Complete Wiki Documentation
Component: wiki | Version:
Keywords: | Blocked By:
Blocking: |
----------------------+------------------------------------------
Today we have decided to create a separate wiki page for this topic. At
the moment some information is available in the LnstIntro document.
What we want is to reduce or completely remove it from here and create a
new page describing how to create your own recipe. This should not be an
xml format reference. It should contain the best practices on what to do
and what not to do.
--
Ticket URL: <https://fedorahosted.org/lnst/ticket/51>
lnst <https://fedorahosted.org/lnst/>
Linux Network Stack Test
10 years, 11 months