On Tue, Feb 25, 2020 at 02:53:25PM +0100, Jan Tluka wrote:
This is an initial code cleanup after major redesign of LNST.
Most of it is removal of code that cannot be used anymore due to API
change. I did also some pylint checks on the code where I found minor
issues.
Jan Tluka (20):
lnst/Slave/NetTestSlave.py: remove NetTestCommand references
remove already ported IcmpPing and Icmp6Ping test modules
remove legacy PacketAssert test module
remove legacy Iperf test module
remove legacy test_modules
remove deprecated regression_tests
move DEFAULT_TIMEOUT definiton from NetTestCommand to Job
remove legacy TestsCommon
remove legacy NetTestCommand class
remove pyrecipes
lnst/Common/Parameters: fix missing parameter in ListParam type_check
lnst/Common/TestRecipe: fix typo
lnst.RecipeCommon.Perf.Results: remove deprecated __setslice__
BaselineEvaluator: fix missing self handle in describe_group_results
remove obsolete NetConfigDevice module
remove obsolete NmConfigDevice module
lnst.Slave.InterfaceManager: add missing import of DeviceError
remove directory obsolete
remove obsolete recipe_conv.py
remove obsolete recipe-schema.rng
lnst/Common/NetTestCommand.py | 571 -----------
lnst/Common/Parameters.py | 4 +-
lnst/Common/TestsCommon.py | 147 ---
lnst/Controller/Job.py | 3 +-
lnst/Controller/Namespace.py | 2 +-
lnst/Controller/NetNamespace.py | 1 -
.../Perf/Evaluators/BaselineEvaluator.py | 2 +-
lnst/RecipeCommon/Perf/Results.py | 16 +-
lnst/RecipeCommon/TestRecipe.py | 2 +-
lnst/Slave/InterfaceManager.py | 3 +-
lnst/Slave/NetConfigDevice.py | 741 ---------------
lnst/Slave/NetTestSlave.py | 19 -
lnst/Slave/NmConfigDevice.py | 888 ------------------
misc/recipe_conv.py | 134 ---
obsolete/SwSwitch/SwSwitch.py | 387 --------
obsolete/SwSwitch/__init__.py | 0
obsolete/Switch/Drivers/SwSwitch.py | 49 -
obsolete/Switch/Drivers/__init__.py | 0
obsolete/Switch/SwitchConfigParse.py | 73 --
obsolete/Switch/SwitchCtl.py | 42 -
obsolete/Switch/SwitchDriversCommon.py | 51 -
obsolete/Switch/__init__.py | 0
obsolete/netconfig.py | 206 ----
obsolete/switchconfig.py | 87 --
obsolete/swswitch.py | 90 --
pyrecipes/3_vlans.py | 34 -
pyrecipes/example.py | 33 -
pyrecipes/ping_flood.py | 48 -
regression-tests/README.md | 112 ---
regression-tests/env/lnst-ctl.conf | 16 -
regression-tests/run-test.sh | 253 -----
regression-tests/tests/0/desc | 6 -
regression-tests/tests/0/run.sh | 24 -
regression-tests/tests/1/desc | 4 -
regression-tests/tests/1/recipe.xml | 33 -
regression-tests/tests/1/run.sh | 12 -
regression-tests/tests/10/desc | 4 -
.../tests/10/prefix-check-taskapi.xml | 33 -
regression-tests/tests/10/prefix-check.py | 15 -
regression-tests/tests/10/prefix-check.xml | 44 -
regression-tests/tests/10/run.sh | 39 -
regression-tests/tests/11/desc | 3 -
regression-tests/tests/11/recipe.xml | 33 -
regression-tests/tests/11/run.sh | 15 -
regression-tests/tests/12/desc | 1 -
regression-tests/tests/12/run.sh | 12 -
regression-tests/tests/12/sm01.xml | 7 -
regression-tests/tests/12/sm02.xml | 7 -
regression-tests/tests/12/xinclude-check.xml | 13 -
regression-tests/tests/13/desc | 1 -
regression-tests/tests/13/run.sh | 22 -
.../tests/13/taskapi-alias-check.py | 9 -
.../tests/13/taskapi-alias-check.xml | 38 -
.../tests/13/taskapi-alias-namespace-check.py | 8 -
.../13/taskapi-alias-namespace-check.xml | 41 -
regression-tests/tests/14/desc | 3 -
regression-tests/tests/14/recipe1.xml | 68 --
regression-tests/tests/14/recipe2.xml | 79 --
regression-tests/tests/14/run.sh | 17 -
regression-tests/tests/15/desc | 3 -
regression-tests/tests/15/recipe.xml | 33 -
regression-tests/tests/15/run.sh | 12 -
regression-tests/tests/16/desc | 3 -
regression-tests/tests/16/recipe.xml | 37 -
regression-tests/tests/16/run.sh | 14 -
regression-tests/tests/17/desc | 3 -
regression-tests/tests/17/recipe.xml | 38 -
regression-tests/tests/17/run.sh | 14 -
regression-tests/tests/18/desc | 6 -
regression-tests/tests/18/recipe.xml | 26 -
regression-tests/tests/18/run.sh | 19 -
regression-tests/tests/19/desc | 3 -
regression-tests/tests/19/recipe.xml | 17 -
regression-tests/tests/19/run.sh | 19 -
regression-tests/tests/2/desc | 5 -
regression-tests/tests/2/recipe.xml | 74 --
regression-tests/tests/2/run.sh | 12 -
regression-tests/tests/20/desc | 3 -
regression-tests/tests/20/recipe1.xml | 47 -
regression-tests/tests/20/recipe2.xml | 31 -
regression-tests/tests/20/run.sh | 20 -
regression-tests/tests/21/desc | 3 -
regression-tests/tests/21/lnst-ctl.conf | 3 -
regression-tests/tests/21/recipe.xml | 55 --
regression-tests/tests/21/run.sh | 18 -
.../tests/21/test_modules/TCPConnection.py | 60 --
.../tests/21/test_tools/tcp_conn/Makefile | 12 -
.../21/test_tools/tcp_conn/lnst-setup.sh | 3 -
.../21/test_tools/tcp_conn/tcp_connect.c | 281 ------
.../tests/21/test_tools/tcp_conn/tcp_listen.c | 330 -------
regression-tests/tests/22/desc | 3 -
regression-tests/tests/22/lnst-ctl.conf | 2 -
regression-tests/tests/22/pool/slave1.xml | 6 -
regression-tests/tests/22/pool/slave2.xml | 6 -
regression-tests/tests/22/recipe.xml | 26 -
regression-tests/tests/22/run.sh | 18 -
regression-tests/tests/23/desc | 3 -
regression-tests/tests/23/lnst-ctl.conf | 2 -
regression-tests/tests/23/recipe.xml | 42 -
regression-tests/tests/23/run.sh | 19 -
.../tests/23/test_modules/IcmpPing.py | 71 --
regression-tests/tests/24/desc | 6 -
regression-tests/tests/24/recipe_fail.xml | 33 -
regression-tests/tests/24/recipe_pass.xml | 33 -
regression-tests/tests/24/run.sh | 22 -
regression-tests/tests/25/desc | 12 -
regression-tests/tests/25/recipe1.xml | 44 -
regression-tests/tests/25/recipe2.xml | 53 --
regression-tests/tests/25/recipe3.xml | 28 -
regression-tests/tests/25/run.sh | 27 -
regression-tests/tests/26/desc | 7 -
regression-tests/tests/26/recipe1.xml | 46 -
regression-tests/tests/26/recipe2.xml | 46 -
regression-tests/tests/26/run.sh | 24 -
regression-tests/tests/27/desc | 10 -
regression-tests/tests/27/recipe1.xml | 32 -
regression-tests/tests/27/recipe2.xml | 32 -
regression-tests/tests/27/recipe3.xml | 31 -
regression-tests/tests/27/recipe4.xml | 31 -
regression-tests/tests/27/recipe5.xml | 32 -
regression-tests/tests/27/recipe6.xml | 30 -
regression-tests/tests/27/recipe7.xml | 30 -
regression-tests/tests/27/recipe8.xml | 32 -
regression-tests/tests/27/run.sh | 48 -
regression-tests/tests/28/desc | 6 -
regression-tests/tests/28/recipe1.py | 20 -
regression-tests/tests/28/recipe1.xml | 16 -
regression-tests/tests/28/recipe2.py | 18 -
regression-tests/tests/28/recipe2.xml | 16 -
regression-tests/tests/28/recipe3.py | 11 -
regression-tests/tests/28/recipe3.xml | 16 -
regression-tests/tests/28/recipe4.py | 15 -
regression-tests/tests/28/recipe4.xml | 16 -
regression-tests/tests/28/run.sh | 34 -
regression-tests/tests/3/desc | 8 -
regression-tests/tests/3/recipe.xml | 21 -
regression-tests/tests/3/run.sh | 12 -
regression-tests/tests/4/desc | 3 -
regression-tests/tests/4/recipe.xml | 43 -
regression-tests/tests/4/run.sh | 19 -
regression-tests/tests/5/desc | 3 -
regression-tests/tests/5/recipe.xml | 29 -
regression-tests/tests/5/run.sh | 20 -
regression-tests/tests/6/desc | 4 -
regression-tests/tests/6/recipe.xml | 35 -
regression-tests/tests/6/run.sh | 19 -
regression-tests/tests/7/desc | 4 -
regression-tests/tests/7/recipe.xml | 24 -
regression-tests/tests/7/run.sh | 19 -
regression-tests/tests/7/task.py | 23 -
regression-tests/tests/8/desc | 3 -
regression-tests/tests/8/recipe.xml | 26 -
regression-tests/tests/8/run.sh | 12 -
regression-tests/tests/9/desc | 3 -
regression-tests/tests/9/recipe.xml | 24 -
regression-tests/tests/9/run.sh | 12 -
regression-tests/tests/9/task.py | 9 -
regression-tests/tests/lib.sh | 67 --
schema-recipe.rng | 715 --------------
test_modules/Custom.py | 31 -
test_modules/DummyFailing.py | 19 -
test_modules/Icmp6Ping.py | 74 --
test_modules/IcmpPing.py | 71 --
test_modules/Iperf.py | 160 ----
test_modules/LinkNeg.py | 59 --
test_modules/Multicast.py | 134 ---
test_modules/NetCat.py | 69 --
test_modules/Netperf.py | 579 ------------
test_modules/PacketAssert.py | 148 ---
test_modules/PktCounter.py | 89 --
test_modules/PktgenTx.py | 93 --
test_modules/TCPConnection.py | 60 --
172 files changed, 18 insertions(+), 9589 deletions(-)
delete mode 100644 lnst/Common/NetTestCommand.py
delete mode 100644 lnst/Common/TestsCommon.py
delete mode 100644 lnst/Slave/NetConfigDevice.py
delete mode 100644 lnst/Slave/NmConfigDevice.py
delete mode 100755 misc/recipe_conv.py
delete mode 100644 obsolete/SwSwitch/SwSwitch.py
delete mode 100644 obsolete/SwSwitch/__init__.py
delete mode 100644 obsolete/Switch/Drivers/SwSwitch.py
delete mode 100644 obsolete/Switch/Drivers/__init__.py
delete mode 100644 obsolete/Switch/SwitchConfigParse.py
delete mode 100644 obsolete/Switch/SwitchCtl.py
delete mode 100644 obsolete/Switch/SwitchDriversCommon.py
delete mode 100644 obsolete/Switch/__init__.py
delete mode 100755 obsolete/netconfig.py
delete mode 100755 obsolete/switchconfig.py
delete mode 100755 obsolete/swswitch.py
delete mode 100644 pyrecipes/3_vlans.py
delete mode 100644 pyrecipes/example.py
delete mode 100644 pyrecipes/ping_flood.py
delete mode 100644 regression-tests/README.md
delete mode 100644 regression-tests/env/lnst-ctl.conf
delete mode 100755 regression-tests/run-test.sh
delete mode 100644 regression-tests/tests/0/desc
delete mode 100755 regression-tests/tests/0/run.sh
delete mode 100644 regression-tests/tests/1/desc
delete mode 100644 regression-tests/tests/1/recipe.xml
delete mode 100755 regression-tests/tests/1/run.sh
delete mode 100644 regression-tests/tests/10/desc
delete mode 100644 regression-tests/tests/10/prefix-check-taskapi.xml
delete mode 100644 regression-tests/tests/10/prefix-check.py
delete mode 100644 regression-tests/tests/10/prefix-check.xml
delete mode 100755 regression-tests/tests/10/run.sh
delete mode 100644 regression-tests/tests/11/desc
delete mode 100644 regression-tests/tests/11/recipe.xml
delete mode 100755 regression-tests/tests/11/run.sh
delete mode 100644 regression-tests/tests/12/desc
delete mode 100755 regression-tests/tests/12/run.sh
delete mode 100644 regression-tests/tests/12/sm01.xml
delete mode 100644 regression-tests/tests/12/sm02.xml
delete mode 100644 regression-tests/tests/12/xinclude-check.xml
delete mode 100644 regression-tests/tests/13/desc
delete mode 100755 regression-tests/tests/13/run.sh
delete mode 100644 regression-tests/tests/13/taskapi-alias-check.py
delete mode 100644 regression-tests/tests/13/taskapi-alias-check.xml
delete mode 100644 regression-tests/tests/13/taskapi-alias-namespace-check.py
delete mode 100644 regression-tests/tests/13/taskapi-alias-namespace-check.xml
delete mode 100644 regression-tests/tests/14/desc
delete mode 100644 regression-tests/tests/14/recipe1.xml
delete mode 100644 regression-tests/tests/14/recipe2.xml
delete mode 100755 regression-tests/tests/14/run.sh
delete mode 100644 regression-tests/tests/15/desc
delete mode 100644 regression-tests/tests/15/recipe.xml
delete mode 100755 regression-tests/tests/15/run.sh
delete mode 100644 regression-tests/tests/16/desc
delete mode 100644 regression-tests/tests/16/recipe.xml
delete mode 100755 regression-tests/tests/16/run.sh
delete mode 100644 regression-tests/tests/17/desc
delete mode 100644 regression-tests/tests/17/recipe.xml
delete mode 100755 regression-tests/tests/17/run.sh
delete mode 100644 regression-tests/tests/18/desc
delete mode 100644 regression-tests/tests/18/recipe.xml
delete mode 100755 regression-tests/tests/18/run.sh
delete mode 100644 regression-tests/tests/19/desc
delete mode 100644 regression-tests/tests/19/recipe.xml
delete mode 100755 regression-tests/tests/19/run.sh
delete mode 100644 regression-tests/tests/2/desc
delete mode 100644 regression-tests/tests/2/recipe.xml
delete mode 100755 regression-tests/tests/2/run.sh
delete mode 100644 regression-tests/tests/20/desc
delete mode 100644 regression-tests/tests/20/recipe1.xml
delete mode 100644 regression-tests/tests/20/recipe2.xml
delete mode 100755 regression-tests/tests/20/run.sh
delete mode 100644 regression-tests/tests/21/desc
delete mode 100644 regression-tests/tests/21/lnst-ctl.conf
delete mode 100644 regression-tests/tests/21/recipe.xml
delete mode 100755 regression-tests/tests/21/run.sh
delete mode 100644 regression-tests/tests/21/test_modules/TCPConnection.py
delete mode 100644 regression-tests/tests/21/test_tools/tcp_conn/Makefile
delete mode 100755 regression-tests/tests/21/test_tools/tcp_conn/lnst-setup.sh
delete mode 100644 regression-tests/tests/21/test_tools/tcp_conn/tcp_connect.c
delete mode 100644 regression-tests/tests/21/test_tools/tcp_conn/tcp_listen.c
delete mode 100644 regression-tests/tests/22/desc
delete mode 100644 regression-tests/tests/22/lnst-ctl.conf
delete mode 100644 regression-tests/tests/22/pool/slave1.xml
delete mode 100644 regression-tests/tests/22/pool/slave2.xml
delete mode 100644 regression-tests/tests/22/recipe.xml
delete mode 100755 regression-tests/tests/22/run.sh
delete mode 100644 regression-tests/tests/23/desc
delete mode 100644 regression-tests/tests/23/lnst-ctl.conf
delete mode 100644 regression-tests/tests/23/recipe.xml
delete mode 100755 regression-tests/tests/23/run.sh
delete mode 100644 regression-tests/tests/23/test_modules/IcmpPing.py
delete mode 100644 regression-tests/tests/24/desc
delete mode 100644 regression-tests/tests/24/recipe_fail.xml
delete mode 100644 regression-tests/tests/24/recipe_pass.xml
delete mode 100755 regression-tests/tests/24/run.sh
delete mode 100644 regression-tests/tests/25/desc
delete mode 100644 regression-tests/tests/25/recipe1.xml
delete mode 100644 regression-tests/tests/25/recipe2.xml
delete mode 100644 regression-tests/tests/25/recipe3.xml
delete mode 100755 regression-tests/tests/25/run.sh
delete mode 100644 regression-tests/tests/26/desc
delete mode 100644 regression-tests/tests/26/recipe1.xml
delete mode 100644 regression-tests/tests/26/recipe2.xml
delete mode 100755 regression-tests/tests/26/run.sh
delete mode 100644 regression-tests/tests/27/desc
delete mode 100644 regression-tests/tests/27/recipe1.xml
delete mode 100644 regression-tests/tests/27/recipe2.xml
delete mode 100644 regression-tests/tests/27/recipe3.xml
delete mode 100644 regression-tests/tests/27/recipe4.xml
delete mode 100644 regression-tests/tests/27/recipe5.xml
delete mode 100644 regression-tests/tests/27/recipe6.xml
delete mode 100644 regression-tests/tests/27/recipe7.xml
delete mode 100644 regression-tests/tests/27/recipe8.xml
delete mode 100755 regression-tests/tests/27/run.sh
delete mode 100644 regression-tests/tests/28/desc
delete mode 100644 regression-tests/tests/28/recipe1.py
delete mode 100644 regression-tests/tests/28/recipe1.xml
delete mode 100644 regression-tests/tests/28/recipe2.py
delete mode 100644 regression-tests/tests/28/recipe2.xml
delete mode 100644 regression-tests/tests/28/recipe3.py
delete mode 100644 regression-tests/tests/28/recipe3.xml
delete mode 100644 regression-tests/tests/28/recipe4.py
delete mode 100644 regression-tests/tests/28/recipe4.xml
delete mode 100755 regression-tests/tests/28/run.sh
delete mode 100644 regression-tests/tests/3/desc
delete mode 100644 regression-tests/tests/3/recipe.xml
delete mode 100755 regression-tests/tests/3/run.sh
delete mode 100644 regression-tests/tests/4/desc
delete mode 100644 regression-tests/tests/4/recipe.xml
delete mode 100755 regression-tests/tests/4/run.sh
delete mode 100644 regression-tests/tests/5/desc
delete mode 100644 regression-tests/tests/5/recipe.xml
delete mode 100755 regression-tests/tests/5/run.sh
delete mode 100644 regression-tests/tests/6/desc
delete mode 100644 regression-tests/tests/6/recipe.xml
delete mode 100755 regression-tests/tests/6/run.sh
delete mode 100644 regression-tests/tests/7/desc
delete mode 100644 regression-tests/tests/7/recipe.xml
delete mode 100755 regression-tests/tests/7/run.sh
delete mode 100644 regression-tests/tests/7/task.py
delete mode 100644 regression-tests/tests/8/desc
delete mode 100644 regression-tests/tests/8/recipe.xml
delete mode 100755 regression-tests/tests/8/run.sh
delete mode 100644 regression-tests/tests/9/desc
delete mode 100644 regression-tests/tests/9/recipe.xml
delete mode 100755 regression-tests/tests/9/run.sh
delete mode 100644 regression-tests/tests/9/task.py
delete mode 100644 regression-tests/tests/lib.sh
delete mode 100644 schema-recipe.rng
delete mode 100644 test_modules/Custom.py
delete mode 100644 test_modules/DummyFailing.py
delete mode 100644 test_modules/Icmp6Ping.py
delete mode 100644 test_modules/IcmpPing.py
delete mode 100644 test_modules/Iperf.py
delete mode 100644 test_modules/LinkNeg.py
delete mode 100644 test_modules/Multicast.py
delete mode 100644 test_modules/NetCat.py
delete mode 100644 test_modules/Netperf.py
delete mode 100644 test_modules/PacketAssert.py
delete mode 100644 test_modules/PktCounter.py
delete mode 100644 test_modules/PktgenTx.py
delete mode 100644 test_modules/TCPConnection.py
--
2.21.1
_______________________________________________
LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/lnst-developers@lists.fedora...
Thanks, looks good. Pushed.
-Ondrej