From: Ondrej Lichtner <olichtne(a)redhat.com>
These were never used and seem to be useless so I'm removing them. I'm
also changing the perf_reverse parameter to have a default value of
False since it makes the logic of using it in the recipe easier (only
check it's value instead of also checking if it's defined).
Signed-off-by: Ondrej Lichtner <olichtne(a)redhat.com>
---
lnst/Recipes/ENRT/BaseEnrtRecipe.py | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/lnst/Recipes/ENRT/BaseEnrtRecipe.py b/lnst/Recipes/ENRT/BaseEnrtRecipe.py
index 68a824a..1c2b062 100644
--- a/lnst/Recipes/ENRT/BaseEnrtRecipe.py
+++ b/lnst/Recipes/ENRT/BaseEnrtRecipe.py
@@ -84,11 +84,7 @@ class BaseEnrtRecipe(PingTestAndEvaluate, PerfRecipe):
perf_iterations = IntParam(default=5)
perf_parallel_streams = IntParam(default=1)
perf_msg_size = IntParam(default=123)
- perf_reverse = BoolParam(mandatory=False)
-
- perf_usr_comment = StrParam(default="")
-
- perf_max_deviation = IntParam(default=10) #TODO required?
+ perf_reverse = BoolParam(default=False)
net_perf_tool = Param(default=IperfFlowMeasurement)
@@ -278,7 +274,7 @@ class BaseEnrtRecipe(PingTestAndEvaluate, PerfRecipe):
)
yield [flow]
- if "perf_reverse" in self.params and self.params.perf_reverse:
+ if self.params.perf_reverse:
reverse_flow = self._create_reverse_flow(flow)
yield [reverse_flow]
--
2.21.0