On 09. 03. 23 10:05, Otto Liljalaakso wrote:
Miro Hrončok kirjoitti 8.3.2023 klo 17.29:
>> On 08. 03. 23 9:29, Zbigniew Jędrzejewski-Szmek wrote:
>>> On Wed, Mar 08, 2023 at 08:13:57AM +0100, Ondrej Nosek wrote:
>>>>
>>>> Changelog (web documentation):
>>>>
https://docs.pagure.org/rpkg/releases/1.66.html
>>>>
https://docs.pagure.org/fedpkg/releases/1.44.html
>>>
>>> In Fedora, the principle is to perform all modifications in
>>> ‘Rawhide’ first. Thus, it makes sense to assume that any work that
>>> happens outside of an established dist-git repository is targeting
>>> Rawhide. Previously, the user had to manually specify --release
>>> rawhide on every invocation.
>>>
>>> That sounds wonderful!
>
> However, maybe it does not work as I expected?
>
> [python-setuptools (bundles %)]$ fedpkg prep
> Not downloading already downloaded setuptools-65.5.1.tar.gz
> Could not execute prep: Could not find the release/dist from branch name bundles
> Please specify with --release
>
> [python-setuptools (bundles %)]$ rpm -q fedpkg
> fedpkg-1.44-2.fc37.noarch
>
> [python-setuptools (bundles %)]$ rpm -q rpkg-common
> rpkg-common-1.66-3.fc37.noarch
Right, it looks like you interpreted "outside of an established dist-git
repository" to cover the case where you do have a Git repository, but are in a
local branch with a custom name. Unfortunately, currently only the case where
there is no Git repository at all is covered.
Mea culpa. I assumed that's the case because I don't use fedpkg outside of git
much.
I presume that in your example you intend to eventually create a pull
request.
Fedpkg should have a great support for that as well, but a bit (just a bit)
more work is needed to cover that case. I suppose that it would be enough to,
instead of printing the error you saw, fall back to using the same default
mechanism that is used for the no-Git case. I will take a look at some point —
unless somebody beats me to it, of course.
Thanks, Otto.
--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok