On Tue, Feb 26, 2019 at 11:39 AM Mamoru TASAKA <mtasaka(a)fedoraproject.org>
wrote:
Mamoru TASAKA wrote on 2019/02/27 2:29:
> Richard Shaw wrote on 2019/02/27 2:23:
>> On Tue, Feb 26, 2019 at 11:17 AM Mamoru TASAKA <
mtasaka(a)fedoraproject.org>
>> wrote:
>>
>>> So... I guess Qt "foreach" behavior changed with gcc9..
>>>
>>
>> Is there any chance this will change or magically get fixed if qt is
>> rebuilt with gcc 9?
>>
>> Thanks,
>> Richard
>>
>
> Well, foreach or Q_FOREACH is just a "#define" macro (from
/usr/include/Qt/qglobal.h and
> /usr/include/QtCore/qglobal.h), so rebuilding qt(4) itself does not
sense.
>
So now I tried to change all "foreach(... , ...)" usage with "for(... :
...)",
actually it seems okay??
https://koji.fedoraproject.org/koji/taskinfo?taskID=33067948
What I did is:
LANG=C grep -rl 'foreach.*,' . | \
xargs sed -i -e '\@foreach.*,@s|foreach\(.*\),|for\1:|'
So now I appreciate it if someone would investigate Q_FOREACH macro.
Thanks Mamoru! As far as you know is this safe to put in an official build?
Thanks,
Richard