-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On Wed, 2018-01-31 at 13:54 +0100, Kamil Dudka wrote:
On Tuesday, January 30, 2018 9:57:39 AM CET Igor Gnatenko wrote:
> brp-ldconfig simply calls `/sbin/ldconfig -N -r "$RPM_BUILD_ROOT"` and
> there
> is no /etc/ld.so.conf under $RPM_BUILD_ROOT when you build... In theory we
> could supply one (empty), but I would ask Florian what would be the best to
> do. --
> -Igor Gnatenko
This change broke the build of libcurl{-minimal} because ldconfig now
operates
on an intermediate layout of the installed shared libraries, which is needed
by the RemovePathPostfixes feature of RPM, instead of the final layout that
is
actually packaged as libcurl and libcurl-minimal.
At the end of %install, the build root contains this:
+ ls -l /builddir/build/BUILDROOT/curl-7.58.0-2.fc28.s390x/usr/lib64
total 8324
lrwxrwxrwx. 1 mockbuild mockbuild 16 Jan 31 12:46 libcurl.so ->
libcurl.so.4.5.0
lrwxrwxrwx. 1 mockbuild mockbuild 16 Jan 31 12:46 libcurl.so.4 ->
libcurl.so.4.5.0
-rwxr-xr-x. 1 mockbuild mockbuild 4398816 Jan 31 12:46 libcurl.so.4.5.0
-rwxr-xr-x. 1 mockbuild mockbuild 4120952 Jan 31 12:46
libcurl.so.4.5.0.minimal
lrwxrwxrwx. 1 mockbuild mockbuild 16 Jan 31 12:46 libcurl.so.4.minimal
-> libcurl.so.4.5.0
drwxr-xr-x. 2 mockbuild mockbuild 24 Jan 31 12:46 pkgconfig
But at the beginning of %check, the build root contains this:
+ ls -l /builddir/build/BUILDROOT/curl-7.58.0-2.fc28.s390x/usr/lib64
total 1172
lrwxrwxrwx. 1 mockbuild mockbuild 16 Jan 31 12:46 libcurl.so ->
libcurl.so.4.5.0
lrwxrwxrwx. 1 mockbuild mockbuild 24 Jan 31 12:46 libcurl.so.4 ->
libcurl.so.4.5.0.minimal
-rwxr-xr-x. 1 mockbuild mockbuild 614896 Jan 31 12:46 libcurl.so.4.5.0
-rwxr-xr-x. 1 mockbuild mockbuild 577760 Jan 31 12:46
libcurl.so.4.5.0.minimal
lrwxrwxrwx. 1 mockbuild mockbuild 16 Jan 31 12:46 libcurl.so.4.minimal ->
libcurl.so.4.5.0
drwxr-xr-x. 2 mockbuild mockbuild 24 Jan 31 12:46 pkgconfig
See that libcurl.so.4 now points to libcurl.so.4.5.0.minimal by mistake.
What is the recommended way to make libcurl{-minimal} build properly again?
Just `%undefine __brp_ldconfig`. And you can safely remove / replace with macro
calls to ldconfig because you are packaging DSO symlinks and it will continue
working fine..
I will think how we can make support for RemovePathPostfixes.
- --
- -Igor Gnatenko
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlpxvrgACgkQaVcUvRu8
X0z61A//an3YDqsC86tA1VCWMgx7gDSutV3eXS1SkvYWGu+h9MlZRTQmoa9alpDd
FFZrYnxt77ln71IvOF+IAhL1MxbwFmkPAU8n9+q6o3jVH1wN8F5iRNzqjyX91StA
Ib/YK781/Bjk4SflsULmqb5sCANeTr1Qb0W4JEd9mE0iGSVZTJ03DC5jheZKw3Lf
UcPaI3jPHv7wztZ6TRzf0abr2e6o77gkYggkC9qq2bZ/XnTUbCsV/82seiF0wwK2
+x1tQLeDFQf+SMJo5WnB4wX1oh/sQBYPEzsbzFaMCCRHY5R21xmYqtM8lXVC2EzW
S2cZ36IsxqljbFR7U3W5TNPZdROTiDEE24Bh1ztZaDx/CG9x65hyb6tbJCuzikPw
HajJjmODcKfsXXESoXGFJ4FQknMkXyCWa8M1HKhTFnR8oeNymbSn2dMEudBWiIQv
SU3NhYjxOkLvPKnXt7JAgXDysNwflEjje8QfvAUFpxAvOAMtBDoNnPfp2si67sMS
sI+iQaF/CBFLYQRqQdFCiPASMUk6H7myeh2/3w/0yjG4tC6gpU7kWa5bvLReZUNU
lVCnhMETnGLbmwMKmZzfg4ARZTeN9BX5vtnMpaxb6Yc3ypfPu4B0YPNA12U1+xKp
CbJsfB09lVOBVGvJVxG8TC6AwgYRAWwLkHoJT57cygOL1Kfvtv0=
=fbEP
-----END PGP SIGNATURE-----