On 09/26/2014 02:23 PM, Richard Hughes wrote:
When to warn them? In rpmbuild? In the koji logs no human ever
reads?
You can get this kind of warning now, if you BR: libappstream-glib and
then do a:
%check
DESTDIR=$RPM_BUILD_ROOT appstream-util check-root
...but this requires the packager to actually add this manually.
An option would be to add libappstream-glib to the minimal koji
buildroot and run the check automatically for every package that's built
in koji.
And same thing with desktop-file-validate, instead of manually adding it
in every package's %check / %install, could just have rpmbuild
automatically run it for all builds.
Of course, we'd need a way to opt out (something like %global
_ignore_desktop_file_validate 1), but that should be easy to do as well.
Would something like that make sense?
--
Kalev