* Panu Matilainen:
On 6/18/19 10:15 AM, Florian Weimer wrote:
> * Panu Matilainen:
>
>> On 6/17/19 4:45 PM, Florian Weimer wrote:
>>> * Panu Matilainen:
>>>
>>>> On 6/13/19 12:54 PM, Miroslav Suchý wrote:
>>>>> This is wrong (not sure if the culprit)
>>>>>
>>>>> %endif %{__with_rebar3}
>>>>>
>>>>> I would rewrite it to:
>>>>>
>>>>> %endif # __with_rebar3
>>>>
>>>> Actually both are wrong, and rpm >= 4.15 will complain (unlike old
>>>> versions). Rpm only supports comments at beginning of line, and this
>>>> only ever worked by accident.
>>>
>>> Would it be possible to bring back the ability to comment on %endif
>>> lines at least? It's nice to have a comment there if the condition is a
>>> screen or two away.
>>
>> Nothing prevents you from putting the comment on the line above:
>>
>> # __with_rebar3
>> %endif
>
> This doesn't follow the usual convention for such comments.
Yeah, but then rpm never officially supported the "usual
convention". It was just another spec parser quirk that they got
through until now (and again, it's only a warning still)
Still it seemed rather useful.
Can you put a macro invocation after %endif, on the same line? If yes,
we could have macro there that expands to nothing.
> Are # lines stripped always, even in scriptlets?
>
No, because whatever is in scriptlets body belongs to the scriptlet
interpreter which certainly is not rpm. Oh, I know...
To that cause, I just submitted
https://github.com/rpm-software-management/rpm/pull/753. Doesn't help
with comments after %endif though.
Thanks. I like the M4 reference.
Florian