On Fri, Apr 22, 2016 at 01:54:03PM -0700, Adam Williamson wrote:
Poking around the current compose status, I noticed that aside from
the
freerdp thing I just sent a mail about, another thing is blocking
Rawhide Workstation live image compose:
https://bugzilla.redhat.com/show_bug.cgi?id=1305108
open-vm-tools-desktop is pulled into the Workstation lives. It requires
ICU. So since ICU was bumped to 57.1, the Workstation lives have failed
to compose because open-vm-tools-desktop has a broken dependency on ICU
56. We can't rebuild open-vm-tools because of that bug.
Upstream bug:
https://github.com/vmware/open-vm-tools/issues/67
the relevant code is here:
https://github.com/vmware/open-vm-tools/blob/master/open-vm-tools/lib/inc...
GCC 6 does not like this:
#define VMW_BIT_MASK(shift) (((1 << (shift - 1)) << 1) - 1)
it produces errors:
/builddir/build/BUILD/open-vm-tools-10.0.0-3000743/lib/include/x86cpuid.h:912:51: error:
result of '-2147483648 << 1' requires 33 bits to represent, but
'int' only has 32 bits [-Werror=shift-overflow=]
#define VMW_BIT_MASK(shift) (((1 << (shift - 1)) << 1) - 1)
BTW I removed CFLAGS+="-Werror" from configure.ac and will encourage
VMware to do the same thing. It doesn't fix the above problem, but
it's the right thing to do.
Rich.
--
Richard Jones, Virtualization Group, Red Hat
http://people.redhat.com/~rjones
Read my programming and virtualization blog:
http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages.
http://libguestfs.org