On Fri, May 31, 2019 at 3:27 PM Frantisek Zatloukal <fzatlouk(a)redhat.com> wrote:
On Fri, May 31, 2019 at 1:22 PM Jan Pazdziora <jpazdziora(a)redhat.com> wrote:
>
> On Fri, May 31, 2019 at 12:53:35PM +0200, Jan Tulak wrote:
> > Hi guys
> >
> > I'm trying to enable gating tests for package system-storage-manager.
> > The tarball contains upstream tests and I would like to use these
> > (with the ability to apply patches to them, same as to the rest of the
> > code). I have a gating.yaml and tests.yml that works in RHEL exactly
> > as I want it, but when I try to apply them to Fedora, I can't get it
> > to work.
> >
> > It looks as the tests are not included in the VM built for the test.
> > If I change tests.yml and use only "run: some_system_command," then
> > the system command is executed.
> >
> > My tests.yml looks very similar to swid-tools, where it works
> > (according to jenkins logs), so I'm cc-ing Jan Pazdziora just in case.
> >
> > I tried to find some solution on
> >
https://docs.fedoraproject.org/en-US/ci/ (and subpages), but if it is
> > there, I didn't notice. I also found some other pages as
> >
https://docs.pagure.org/greenwave/package-specific-policies.html, with
> > the same result.
> >
> > I'm using this PR to start the tests:
> >
https://src.fedoraproject.org/rpms/system-storage-manager/pull-request/1
> > A failed run:
https://jenkins-continuous-infra.apps.ci.centos.org/blue/organizations/je...
> >
> > Any ideas what I'm doing wrong? gating.yaml and tests.yml bellow.
>
> [2019-05-31T08:59:54.127Z] stdout: |-
> [2019-05-31T08:59:54.127Z] Test: smoke
> [2019-05-31T08:59:54.127Z] Command: ./test.py --system --logs
> [2019-05-31T08:59:54.127Z] Work dir: /var/str/source
> [2019-05-31T08:59:54.127Z] Artifacts dir: /tmp/artifacts
> [2019-05-31T08:59:54.127Z] Timeout: 0
> [2019-05-31T08:59:54.127Z] /usr/bin/env: python: No such file or directory
> [2019-05-31T08:59:54.127Z] Run test 'smoke': done. Test's exit code:
127
> [2019-05-31T08:59:54.127Z] smoke (problem with test execution)
>
> Could the missing python be the culprit?
>
I didn't look too much at the code, but can you try to replace Shebang in upstream
tests from unversioned python ( #!/usr/bin/env python ) to explicitly require either
python2 or python3 ?
Thanks both for spotting it. I'm trying to test it with a new patch, but
something complains:
[2019-05-31T14:23:09.334Z] + git -c 'user.name=Fedora CI' -c
user.email=ci(a)lists.fedoraproject.org merge pr -m 'Fedora CI pipeline'
[2019-05-31T14:23:09.335Z] Auto-merging python3-sphinx.patch
[2019-05-31T14:23:09.335Z] CONFLICT (add/add): Merge conflict in
python3-sphinx.patch
[2019-05-31T14:23:09.335Z] Automatic merge failed; fix conflicts and
then commit the result.
Ignore the name of the file, I tried to use an existing patch name
when I got the same error about the spec file first after adding a new
one.
fedpkg local/mockbuild works ok. It looks as if I can't modify
existing files in the PR, only add new ones, from what I tried. :(
Thanks,
Jan