On Thu, Jan 19, 2023 at 3:36 PM Robbie Harwood <rharwood(a)redhat.com> wrote:
> Would you see a value in e.g. some kind of a robot reminding
> maintainers of such obsolete code? (e.g. new RPMinspect or ZUUL CI
> check)
Please don't.
Would you mind expanding your answer a bit, please?
I'd like to learn why people would (not) like such a check or reminder.
Michal
--
Michal Schorm
Software Engineer
Core Services - Databases Team
Red Hat
--
On Thu, Jan 19, 2023 at 3:36 PM Robbie Harwood <rharwood(a)redhat.com> wrote:
>
> Michal Schorm <mschorm(a)redhat.com> writes:
>
> > While playing around with Sourcegraph, which indexed all Fedora
> > package repositories, I was able to craft a query listing all '%if'
> > conditionals referencing Fedora releases that reached EOL.
> >
> > Do you agree it would be safe to remove such conditionals and the code
> > they hold ?
>
> Yes, at maintainer discretion.
>
> > Do you agree that removing obsolete code such as this brings value to
> > the package codebase ?
>
> No - it's annoying code churn that usually serves no purpose. If
> maintainers want them gone, generally they'll remove them.
>
> Would you see a value in e.g. some kind of a robot reminding
> maintainers of such obsolete code? (e.g. new RPMinspect or ZUUL CI
> check)
Please don't.
>
> Be well,
> --Robbie