On Sat, 2019-10-19 at 00:11 +0200, Kevin Kofler wrote:
Adam Williamson wrote:
> Eh. I don't think it's a particularly bad hack at all. It's simple,
> labelled, we know what it does, and it's inherently limited (it'll
> never do anything outside of an upgrade to F31).
That's exactly what makes this such a bad hack in my eyes. It "fixes" one
particular instance of this general issue, one that was found during
upgrades from F30 to F31. It does not fix any other instances of the bug,
even ones that could appear in the future in upgrades from F29 updates or
F30 updates to F31 updates. It is also a short-term fix, because the exact
same issue with libgit2 will likely still happen on upgrades from F30 to
F32, and the workaround is explicitly not applied there.
That's because it's intended to have a proper fix before F32 comes out.
--
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net