On Wed, 2020-06-03 at 15:31 -0600, Chris Murphy wrote:
On Wed, Jun 3, 2020 at 1:07 PM Simo Sorce <simo(a)redhat.com>
wrote:
> On Tue, 2020-06-02 at 21:58 -0700, John M. Harris Jr wrote:
> > On Tuesday, June 2, 2020 9:45:45 PM MST Chris Murphy wrote:
> > > On Tue, Jun 2, 2020 at 10:28 PM Samuel Sieb <samuel(a)sieb.net>
wrote:
> > >
> > > > I would expect that using an encrypted partition for swap should be
> > > > sufficient to allow it though.
> > >
> > > Unfortunately not. Encryption provides no integrity or authenticity.
> > > The original set of patches for signed and authenticated hibernation
> > > images called for the use of an HMAC for signing, and upstream
> > > considered this insufficient and asked why not use AES-GCM to provide
> > > a real AE (authenticated encryption) model.
> >
> > In what way do you believe it's not sufficient?
>
> AES GCM Is generally *not* a good algorithm for disk encryption so I am
> not sure why this is being brought up, HMAC is sufficient to verify
> integrity.
I don't know either. This is the discussion I'm referring to, for full context:
https://lkml.org/lkml/2019/1/9/828
Alright it was just a question and not a strong suggestion, nothing to
see (I do not want to go down a rabbit hole here anyway it is not
relevant to this discussion).
--
Simo Sorce
RHEL Crypto Team
Red Hat, Inc