On Monday, 5 August 2019 18:05:27 CEST J. Scheurich wrote:
Hi,
(Since the last update ?) fedora-review seams to not work:
I am using
Spec URL:
ftp://ftp.ourproject.org/pub/wdune/vcglib.spec
SRPM URL:
ftp://ftp.ourproject.org/pub/wdune/vcglib-1.0.1-1.src.rpm
as a testcase.
$ fedora-review -n vcglib
INFO: Processing local files: vcglib
INFO: Getting .spec and .srpm Urls from : Local files in /home/home/mufti
INFO: --> SRPM url: file:///home/home/mufti/vcglib-1.0.1-1.src.rpm
INFO: --> Spec url: file:///home/home/mufti/vcglib.spec
INFO: Using review directory: /home/home/mufti/review-vcglib
ERROR: Exception down the road... (logs in
/home/mufti/.cache/fedora-review.log)
$ less /home/mufti/.cache/fedora-review.log
...
08-05 17:51 root INFO --> SRPM url:
file:///home/home/mufti/vcglib-1.0.1-1.src.rpm
08-05 17:51 root INFO --> Spec url:
file:///home/home/mufti/vcglib.spec
08-05 17:51 root DEBUG find_urls completed: 0.010
08-05 17:51 root INFO Using review directory:
/home/home/mufti/review-vcglib
08-05 17:51 root DEBUG Avoiding init of working mock root
08-05 17:51 root DEBUG Url download completed: 2.384
08-05 15:51 root DEBUG Exception down the road...
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
line 236, in run
self._do_run(outfile)
File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
line 226, in _do_run
self._do_report(outfile)
File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
line 99, in _do_report
...
As far as i understand python, a "BaseException" occored in
self._do_run(outfile):
$ less +232 /usr/lib/python3.7/site-packages/FedoraReview/review_helper.py
self.log.debug("fedora-review %s %s started", __version__,
BUILD_FULL)
self.log.debug("Command line: %s", " ".join(sys.argv))
try:
rcode = 0
self._do_run(outfile)
except ReviewError as err:
if isinstance(err, SpecParseReviewError):
nvr = _Nvr(self.bug.get_name())
result = SimpleTestResult(
"SpecFileParseError", "Can't parse the spec file:
",
str(err)
)
write_xml_report(nvr, [result])
self.log.debug("ReviewError: %s", str(err), exc_info=True)
if not err.silent:
msg = "ERROR: " + str(err)
if err.show_logs:
msg += " (logs in " + Settings.session_log + ")"
self.log.error(msg)
rcode = err.exitcode
except BaseException:
self.log.debug("Exception down the road...", exc_info=True)
self.log.error(
"Exception down the road... (logs in %s)",
Settings.session_log
...
What i am doing wrong ?
so long
MUFTI
What's your version of fedora-review? You should have 0.7.2
Name : fedora-review
Version : 0.7.2
Release : 1.fc30
Architecture : noarch
Size : 626 k
Source : fedora-review-0.7.2-1.fc30.src.rpm
Repository : @System
From repo : updates-testing
Summary : Review tool for fedora rpm packages
URL :
https://pagure.io/FedoraReview
License : GPLv2+
Description : This tool automates much of the dirty work when reviewing a
package
: for the Fedora Package Collection like:
:
: * Downloading SRPM & SPEC.
: * Download upstream source
: * Check md5sums
: * Build and install package in mock.
: * Run rpmlint.
: * Generate a review template, which becomes the starting
: point for the review work.
:
: The tool is composed of plugins, one for each supported
language.
: As of today, there is plugins for C/C++, Ruby, java, R, perl
and
: python. There is also support for external tests that can be
written
: in a simple way in bash.
For you SPEC, you should drop the main package and only keep devel.
Drop %global debug_package %{nil} and make the package noarch
Use: Source:
https://github.com/cnr-isti-vclab/vcglib/archive/v%{version}/%
{name}-%{version}.tar.gz
Use cp -a to keep attributes: cp -ar vcg img %{buildroot}%{_includedir}/%
{name}
Remove trailing spaces
Not needed:
mkdir -p %{buildroot}%{_docdir}/%{name}
install -m 644 README.md %{buildroot}%{_docdir}/%{name}
It is automatically included when you use %doc README.md