On 27/02/13 18:03, Jamie Nguyen wrote:
Hi Enrico,
I want to clarify that my whitespace changes were an attempt to make the
spec more legible for everyone, not myself. I also feel it would have
been "nicer" for you to ask me to revert the changes rather than
reverting them yourself, since I did go through the effort of making the
changes and helping you to update and fix the package, but that's just a
small suggestion.
Anyway, I agree that it would perhaps have been better to split the
commit into chunks. Thus, I post below a patch series that includes all
the various changes in easily digestible chunks.
I just want to clarify here the reasoning for each patch.
This custom macro is rather confusing to hard to understand There's no
real need for it.
This custom macro here just makes it harder to read the spec as the bits
inside are not in the place that most people would expect.
Not needed for Fedora 17 and 18. I have adopted your orphaned EPEL 5 and
EPEL 6 branches, and I'm fine with these macros not being present in the
Fedora specs.
The main "tor" package is empty. There is no reason for it to be, and no
reason for the others to be subpackages.
This is an unnecessary dependency and I see no benefit for it.
This is not required.
This will help to make sure some sane defaults are set. This was
recommended by upstream.
This matches the defaults in the upstream RPM packages.
The SPEC is also 100 lines shorter :)
--
Jamie Nguyen