On Tue, Apr 15, 2014 at 02:14:25PM +0300, Panu Matilainen wrote:
On 04/15/2014 01:26 PM, Richard W.M. Jones wrote:
> NOTE: If you are in the CC of this email, then you don't need to do
> anything. I will fix your package for you. However you
> should still read the email.
>
>Some OCaml spec files do the following:
>
> ExclusiveArch: %{ocaml_arches}
>
>This is always incorrect for several reasons:
>
>(1) This macro is provided by redhat-rpm-config, and has the wrong
>list of architectures.
>
>(2) OCaml compiles on all architectures.
>
>There may be some packages using this macro to mean "I need the OCaml
>native code compiler", which is still wrong, but I'm going to fix this
>by adding the following macros to the RPM config:
>
> %ocaml_native_compiler # all arches that support native compilation
>
> %ocaml_natdynlink # all arches that support native dynamic linking
>
Not that it matters to me, but these names seem a bit inconsistent.
Why not %ocaml_native_dynlink to go with %ocaml_native_compiler? Its
not any longer :)
The feature upstream is called "natdynlink", so I guess it's better to
keep the shorter name.
Rich.
--
Richard Jones, Virtualization Group, Red Hat
http://people.redhat.com/~rjones
Read my programming and virtualization blog:
http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html