On Thu, Jun 03, 2021 at 03:51:59PM -0400, Tom Callaway wrote:
I have landed rpmlint 2.0.0 in rawhide, along with Mirek Suchý's
toml
configs (with updates for the licenses.toml). PRs, bug reports, and
suggestions welcome.
Thanks for doing this!
I gave it a go:
systemd.spec: E: specfile-error rpm: /usr/bin/rpmspec: No such file
or directory
→ seems to be missing some dep?
rpmlint: 2.0.0
configuration:
/usr/lib/python3.9/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
→ can we please please move all those files under /usr somewhere? Those are packaged
files that users should never modify locally (they should add per-package overrides
instead…).
$ rpmlint -i systemd
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
Traceback (most recent call last):
File "/usr/bin/rpmlint", line 33, in <module>
sys.exit(load_entry_point('rpmlint==2.0.0', 'console_scripts',
'rpmlint')())
File "/usr/lib/python3.9/site-packages/rpmlint/cli.py", line 174, in lint
sys.exit(lint.run())
File "/usr/lib/python3.9/site-packages/rpmlint/lint.py", line 100, in run
return self._run()
File "/usr/lib/python3.9/site-packages/rpmlint/lint.py", line 69, in _run
self.validate_installed_packages(self._load_installed_rpms(self.options['installed']))
File "/usr/lib/python3.9/site-packages/rpmlint/lint.py", line 205, in
validate_installed_packages
self.run_checks(pkg)
File "/usr/lib/python3.9/site-packages/rpmlint/lint.py", line 258, in
run_checks
fn(pkg)
File "/usr/lib/python3.9/site-packages/rpmlint/checks/TmpFilesCheck.py", line
34, in check
self._check_tmpfile_in_filelist(pkgfile, pkg)
File "/usr/lib/python3.9/site-packages/rpmlint/checks/TmpFilesCheck.py", line
79, in _check_tmpfile_in_filelist
with open(pkgfile.path) as inputf:
FileNotFoundError: [Errno 2] No such file or directory:
'/tmp/rpmlint.systemd.uqz1l_h2/usr/lib/tmpfiles.d/README'
→ I'm not sure what's going on here. /usr/lib/tmpfiles.d/README exists.
Zbyszek