Vreman, Peter - Acision wrote:
Currently the webui search does not work because it misses required
values for the paging. Also paging is not supported so a query for ‘*’
can generate a huge list.
Hi Peter,
Thanks for the patch, a few questions first off...
Do you mean it "doesn't work", or just that it doesn't page the output
(I agree, the search results could get /very/ long, which is not useful)?
I agree with the latter.
Attached is a prototype that adds also paging to the webui search for
the distro’s.
What it does:
- All paging is done in remote API
- Remote API Find method will include paging functionality.
- WebUI list also uses the remote API find function with empty criteria
- WebUI search will only show the criteria builder, the search will be
done by the list page
- Add a $pageinfo$ item to the find results list. This contains the
paging information about the returned list. This item needs to be
stripped by the WUI/TUI
Possible improvements:
- For securitie save search criteria dictionary in a cache instead of
passing them as string on the http request. Benefit is that saving
search criteria to disk can also be implemented
Can you explain why you think this is a a security issue, are you
worried about the search criteria being logged? If so, they could be
passed as POST data. I'm also a bit unclear
about what you might have in mind for saved searches. (the URLs would
definitely allow that).
Anyway, if you can submit your patches using "git-format-patch" I can be
sure I can apply them. Yours were generated with diff and can't be
applied, for instance, there is some noise:
Only in build/cobbler/webui: master.py
Only in build/config: modules.conf
Only in build/config: settings
Only in build/config: version
Only in build/docs: cobbler.1.gz
Only in build/docs: cobbler.html
Only in build: pod2htmd.tmp
Only in build: pod2htmi.tmp
Etc...
If you can resubmit those I can look at testing this later this week.
Thanks!
Please provide feedback if this is a good approach.
Regards,
Peter
This e-mail and any attachment is for authorised use by the intended
recipient(s) only. It may contain proprietary material, confidential
information and/or be subject to legal privilege. It should not be
copied, disclosed to, retained or used by, any other party. If you are
not an intended recipient then please promptly delete this e-mail and
any attachment and all copies and inform the sender. Thank you.
------------------------------------------------------------------------
_______________________________________________
cobbler-devel mailing list
cobbler-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/cobbler-devel