Leonid Flaks wrote:
Michael DeHaan wrote:
> On 07/14/2009 08:05 PM, Leonid Flaks wrote:
>
>> Jeff Schroeder wrote:
>>
>>> Please do not fork a subshell here. Use an if statement so the code is
>>> more readable. If only there was PEP8 for bash :)
>>> if [ $? -eq 0 ]; then
>>>
Big oops here -eq should be replaced with -ne
Just learned the hard way.
>>> rm -rf /tmp/$tmpdir
>>> continue
>>> fi
>>>
>>> Seems reasonable.
>>>
>>>
>>>
>> Thanks for correction. Always good to know that the original author is
>> watching ;-)
>>
>> git diff attached.
>>
>>
>> Leon
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>>
> Source control tip --
>
> You might want to consider starting a branch of cobbler on github, as
> this allows me to just merge your tree without having to manually apply
> multiple patches that depend on one another.
>
> I'd encourage everyone to check it out, really... good stuff.
>
> --Michael
>
>
Michael,
I am not including a patch hoping to get github going later today.
Fixed that nasty 'oops' which prevented snippet keep_ssh_host_keys from
working -
if [ $? -eq 0 ]; then
is replaced with
if [ $? -ne 0 ]; then
and the snippet is working again. I also did the same change with
keep_cfengine_keys.
The changes are done at
http://github.com/lflaks/cobbler/tree/0f68efc706ddec34c80ab611a78b0853165...
and
http://github.com/lflaks/cobbler/tree/0f68efc706ddec34c80ab611a78b0853165...
Leon