Change in vdsm[master]: tool.service: avoid execCmd(raw=False)
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: tool.service: avoid execCmd(raw=False)
......................................................................
tool.service: avoid execCmd(raw=False)
tool.service is the only place where we use raw=False to split lines in
command output. However, we concatenate these lines immediately
afterwards, or ignore them.
This patch would enable the removal of the `raw` argument from execCmd
in a future patch.
Change-Id: I7530451496c41d1f3568e263f1087a92a8f0f3bb
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/service.py
1 file changed, 4 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/80213/1
diff --git a/lib/vdsm/tool/service.py b/lib/vdsm/tool/service.py
index b720b4a..f7fd9e7 100644
--- a/lib/vdsm/tool/service.py
+++ b/lib/vdsm/tool/service.py
@@ -30,11 +30,7 @@
from vdsm.common.cmdutils import CommandPath
from . import expose, UsageError, ExtraArgsError
-from ..commands import execCmd as _execCmd
-
-
-def execCmd(argv, raw=True, *args, **kwargs):
- return _execCmd(argv, raw=raw, *args, **kwargs)
+from ..commands import execCmd
_SYSTEMCTL = CommandPath("systemctl",
@@ -108,10 +104,10 @@
@functools.wraps(systemctlFun)
def wrapper(srvName):
cmd = [_SYSTEMCTL.cmd, "--no-pager", "list-unit-files"]
- rc, out, err = execCmd(cmd, raw=False)
+ rc, out, err = execCmd(cmd)
if rc != 0:
raise ServiceOperationError(
- "Error listing unit files", '\n'.join(out), '\n'.join(err))
+ "Error listing unit files", out, err)
fullName = srvName
# If unit file type was specified, don't override it.
if srvName.count('.') < 1:
@@ -179,7 +175,7 @@
@functools.wraps(initctlFun)
def wrapper(srvName):
cmd = [_INITCTL.cmd, "usage", srvName]
- rc, out, err = execCmd(cmd, raw=False)
+ rc, out, err = execCmd(cmd)
if rc != 0:
raise ServiceNotExistError("%s is not an Upstart service" %
srvName)
--
To view, visit https://gerrit.ovirt.org/80213
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7530451496c41d1f3568e263f1087a92a8f0f3bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 9 months
Change in vdsm[master]: checkimages hook: split line for readability
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: checkimages hook: split line for readability
......................................................................
checkimages hook: split line for readability
Change-Id: Ic7ae180c3386ed7991150cff4ce5e0d589500c1d
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm_hooks/checkimages/before_vm_start.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/80394/1
diff --git a/vdsm_hooks/checkimages/before_vm_start.py b/vdsm_hooks/checkimages/before_vm_start.py
index 31b123d..ee307cf 100755
--- a/vdsm_hooks/checkimages/before_vm_start.py
+++ b/vdsm_hooks/checkimages/before_vm_start.py
@@ -84,7 +84,8 @@
sys.stderr.write('Increate timeout or check image availability.')
sys.exit(2)
- ((out, err), rc) = (p.communicate(), p.returncode)
+ out, err = p.communicate()
+ rc = p.returncode
if rc == 0:
sys.stderr.write('checkimages: %s image check returned: %s\n' %
--
To view, visit https://gerrit.ovirt.org/80394
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7ae180c3386ed7991150cff4ce5e0d589500c1d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 9 months
Change in vdsm[master]: dpdk: call flush ip only on non dpdk devices
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: dpdk: call flush ip only on non dpdk devices
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/80688/1/lib/vdsm/network/ifacquire.py
File lib/vdsm/network/ifacquire.py:
Line 155: return
Line 156: # TODO: Tell NetworkManager to unmanage this iface.
Line 157: dhclient.kill(iface, family=4)
Line 158: dhclient.kill(iface, family=6)
Line 159: if not dpdk.is_dpdk(iface):
does dhclient run on dpdk iface? wouldn't it be better to bail off early, just as if the iface did not exist?
--
To view, visit https://gerrit.ovirt.org/80688
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia768a1fbb6c17bf524cd4bf16abd742cb942bd2e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 9 months
Change in vdsm[master]: net: Remove unused function: ifaceUsed
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80738 )
Change subject: net: Remove unused function: ifaceUsed
......................................................................
net: Remove unused function: ifaceUsed
Change-Id: I27512014a460b49a06f071a9777d825a6d0fc842
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/netinfo/cache.py
1 file changed, 0 insertions(+), 19 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/80738
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I27512014a460b49a06f071a9777d825a6d0fc842
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[master]: net: Remove unused function: ifaceUsed
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Remove unused function: ifaceUsed
......................................................................
Patch Set 1: Code-Review+2
heh, last user dropped in commit 8eeedf1
--
To view, visit https://gerrit.ovirt.org/80738
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27512014a460b49a06f071a9777d825a6d0fc842
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[master]: vdsm tool configurators: bond_defaults - do not depend on time
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80750 )
Change subject: vdsm tool configurators: bond_defaults - do not depend on time
......................................................................
vdsm tool configurators: bond_defaults - do not depend on time
The bond defaults dump is considered updated if it exists (as it is
created per boot, and its content is dependent on the kernel).
The existing time check (verifying if the period elapsed from the file
update is no older then the time elapsed from the system boot) is no
longer needed, as the dump is placed under /var/run which is assured
to be cleaned on boot.
This patch removes the time checks which are not valid when the time is
updated during the boot.
Change-Id: Ia32455d36d600410a0b792f4e7045b97a08afc70
Bug-Url: https://bugzilla.redhat.com/1482014
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/tool/configurators/bond_defaults.py
1 file changed, 1 insertion(+), 17 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/80750
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia32455d36d600410a0b792f4e7045b97a08afc70
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[master]: vdsm tool configurators: bond_defaults - do not depend on time
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm tool configurators: bond_defaults - do not depend on time
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/80750
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia32455d36d600410a0b792f4e7045b97a08afc70
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[ovirt-4.1]: vm: Log changes in drive extension info
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/80428 )
Change subject: vm: Log changes in drive extension info
......................................................................
vm: Log changes in drive extension info
Each time drives' capacity, allocation, or physical change, log a debug
log with the new values. This log will allow easy debugging when lower
level component misbehave.
Here is an example log when starting a VM:
2017-08-02 02:54:24,468+0300 DEBUG (periodic/0) [virt.vm]
(vmId='f33a7fbc-3dab-448c-bb41-204eccee70ba') Extension info for drive
sda volume 13b40805-a43b-4c0e-9a0b-0c03a2e4ecbb:
BlockInfo(capacity=8589934592L, allocation=0L, physical=1073741824L) (vm:1057)
The allocation value is 0, since qemu did not write anything yet to this
drive. Once qemu write to the drive, we get the correct allocation:
2017-08-02 02:54:38,473+0300 DEBUG (periodic/1) [virt.vm]
(vmId='f33a7fbc-3dab-448c-bb41-204eccee70ba') Extension info for drive
sda volume 13b40805-a43b-4c0e-9a0b-0c03a2e4ecbb:
BlockInfo(capacity=8589934592L, allocation=2490368L, physical=1073741824L)
(vm:1057)
Change-Id: I68701bcb1b83295f346139b2aed64b9221a4ee44
Bug-Url: https://bugzilla.redhat.com/1461536
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/virt/vm.py
M vdsm/virt/vmdevices/storage.py
2 files changed, 20 insertions(+), 2 deletions(-)
Approvals:
Adam Litke: Looks good to me, but someone else must approve
Nir Soffer: Verified
Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/80428
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68701bcb1b83295f346139b2aed64b9221a4ee44
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[ovirt-4.1]: vm: Log changes in drive extension info
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: vm: Log changes in drive extension info
......................................................................
Patch Set 3: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/80428
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68701bcb1b83295f346139b2aed64b9221a4ee44
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[ovirt-4.1]: vm: Log changes in drive extension info
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: vm: Log changes in drive extension info
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/80428
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68701bcb1b83295f346139b2aed64b9221a4ee44
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months