Change in vdsm[ovirt-4.1]: vm: Use time.Clock for timing extend flow
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/80427 )
Change subject: vm: Use time.Clock for timing extend flow
......................................................................
vm: Use time.Clock for timing extend flow
Use the new clock facility to record detailed timing of the extension
process. We record:
- total: the time from detecting that a drive needs extension until the
guest can see the new size. When extending during live storage
migration, this time includes the time to extend the replica and the
volume.
- extend-replica: The time to extend the replica volume during live
storage migration.
- refresh-replica: The time to refresh the replica volume after it was
extended during live storage migration.
- extend-volume: The time to extend the drive volume.
- refresh-volume: The time to refresh the drive volume after it was
extended.
Here is an example log during live storage migration from block storage
to block storage - both the volume and the replica are extended:
2017-07-31 02:39:33,390+0300 INFO (mailbox-hsm/0) [virt.vm]
(vmId='338f0c16-286a-4250-937a-e65f1fdaeedd') Extend volume
c951edf1-16aa-4a8e-9197-cdec7c893dca completed
<Clock(total=6.30, extend-replica=2.08, refresh-replica=0.13,
extend-volume=3.98, refresh-volume=0.11)> (vm:1259)
Here is an example log during live storage migration from block storage
to file storage - only the volume is extended:
2017-07-31 02:43:46,356+0300 INFO (mailbox-hsm/1) [virt.vm]
(vmId='338f0c16-286a-4250-937a-e65f1fdaeedd') Extend volume
cad101f2-dedd-4b5e-a3db-49370ff3813a completed
<Clock(total=4.36, extend-volume=4.18, refresh-volume=0.18)> (vm:1259)
Here is an example log during live storage migration from file storage to
block storage - only the replica is extended:
2017-07-31 02:59:22,390+0300 INFO (mailbox-hsm/1) [virt.vm]
(vmId='338f0c16-286a-4250-937a-e65f1fdaeedd') Extend replica
37b8493e-f9d3-4cbe-bc2a-783303dd1a2e completed
<Clock(total=2.31, extend-replica=2.12, refresh-replica=0.19)> (vm:1198)
Change-Id: I23a5cdb8197fd081e28a39de23f38931c0f79e41
Bug-Url: https://bugzilla.redhat.com/1461536
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 42 insertions(+), 24 deletions(-)
Approvals:
Adam Litke: Looks good to me, but someone else must approve
Nir Soffer: Verified
Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/80427
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23a5cdb8197fd081e28a39de23f38931c0f79e41
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[ovirt-4.1]: vm: Use time.Clock for timing extend flow
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: vm: Use time.Clock for timing extend flow
......................................................................
Patch Set 3: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/80427
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a5cdb8197fd081e28a39de23f38931c0f79e41
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[ovirt-4.1]: vm: Use time.Clock for timing extend flow
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: vm: Use time.Clock for timing extend flow
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/80427
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a5cdb8197fd081e28a39de23f38931c0f79e41
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[ovirt-4.1]: time: Add a Clock utility for timing complex flows
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/80426 )
Change subject: time: Add a Clock utility for timing complex flows
......................................................................
time: Add a Clock utility for timing complex flows
This helps to record the time for multiple steps in a complex flow and
log the results. This will be used in the next patch for timing extend
disk flow.
Changes from master:
- There is no vdsm.common.time module, adding Clock to utils, near
monotonic_time.
Change-Id: I91d238ebb79d78c625c95892d19718129c015046
Bug-Url: https://bugzilla.redhat.com/1461536
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M lib/vdsm/utils.py
A tests/common/time_test.py
2 files changed, 176 insertions(+), 0 deletions(-)
Approvals:
Adam Litke: Looks good to me, but someone else must approve
Nir Soffer: Verified
Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/80426
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I91d238ebb79d78c625c95892d19718129c015046
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[ovirt-4.1]: time: Add a Clock utility for timing complex flows
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: time: Add a Clock utility for timing complex flows
......................................................................
Patch Set 2: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/80426
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d238ebb79d78c625c95892d19718129c015046
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[ovirt-4.1]: time: Add a Clock utility for timing complex flows
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: time: Add a Clock utility for timing complex flows
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/80426
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d238ebb79d78c625c95892d19718129c015046
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[ovirt-4.1]: vm: Log the time took to extend a volume
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/79969 )
Change subject: vm: Log the time took to extend a volume
......................................................................
vm: Log the time took to extend a volume
Measure the time to extend a volume from the time we decided that the
volume should be extended, until the time the volume is refreshed after
the extension.
Note that during live storage migration we extend the replica volume
before extending the original volume, so the time to extend the original
volume includes the time to extend the replica.
Changes from master version:
- Use monotonic_time from vdsm.utils.
Change-Id: Ie970247f7694da644e4789b674884ceb8e4210be
Bug-Url: https://bugzilla.redhat.com/1461536
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 18 insertions(+), 5 deletions(-)
Approvals:
Adam Litke: Looks good to me, but someone else must approve
Nir Soffer: Verified
Yaniv Bronhaim: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/79969
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie970247f7694da644e4789b674884ceb8e4210be
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[ovirt-4.1]: vm: Log the time took to extend a volume
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: vm: Log the time took to extend a volume
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79969
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie970247f7694da644e4789b674884ceb8e4210be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: virt: metadata: support network storage
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: metadata: support network storage
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/80699
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib80f6fe54d7b7963f3d914f40065ea1e5d16f45b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: cmdutils: add env to exec_sync_bytes()'s args
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: cmdutils: add env to exec_sync_bytes()'s args
......................................................................
cmdutils: add env to exec_sync_bytes()'s args
Expose Popen's env argument throught exec_sync_bytes()
Change-Id: I109c50c4dd85347e12e8a9a11963b0cded685536
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/common/cmdutils.py
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/79694/1
diff --git a/lib/vdsm/common/cmdutils.py b/lib/vdsm/common/cmdutils.py
index 26e08a7..c4b1d31 100644
--- a/lib/vdsm/common/cmdutils.py
+++ b/lib/vdsm/common/cmdutils.py
@@ -110,11 +110,12 @@
BlockIO = 'BlockIO'
-def exec_sync_bytes(cmds):
+def exec_sync_bytes(cmds, env=None):
logging.debug(cmdutils.command_log_line(cmds))
p = Popen(
- cmds, close_fds=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+ cmds, close_fds=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE,
+ env=env)
out, err = p.communicate()
--
To view, visit https://gerrit.ovirt.org/79694
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I109c50c4dd85347e12e8a9a11963b0cded685536
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 10 months