Change in vdsm[ovirt-4.1]: network: remove ip from a nic used by a removed network
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80835 )
Change subject: network: remove ip from a nic used by a removed network
......................................................................
network: remove ip from a nic used by a removed network
Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1432386
---
M lib/vdsm/network/configurators/ifcfg.py
M tests/network/func_net_basic_test.py
M tests/network/func_static_ip_test.py
3 files changed, 83 insertions(+), 19 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/80835
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[ovirt-4.1]: network: remove ip from a nic used by a removed network
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: remove ip from a nic used by a removed network
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/80835
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[ovirt-4.1]: net: Report lldp through new getLldp command
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80194 )
Change subject: net: Report lldp through new getLldp command
......................................................................
net: Report lldp through new getLldp command
Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: I1e5e81cfbfe9c714d8173ecd6ee20f8b59bd14fe
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
(cherry picked from commit ada4b07375d8e41782177760b75e7c125430dc5f)
---
M lib/vdsm/api/vdsm-api.yml
M lib/vdsm/rpc/Bridge.py
M lib/vdsm/supervdsm_api/network.py
M vdsm/API.py
4 files changed, 80 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/80194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e5e81cfbfe9c714d8173ecd6ee20f8b59bd14fe
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[ovirt-4.1]: net: Introduce the LLDPAD driver with an LLDP interface
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80187 )
Change subject: net: Introduce the LLDPAD driver with an LLDP interface
......................................................................
net: Introduce the LLDPAD driver with an LLDP interface
The Link Layer Discovery Protocol (LLDP) is a vendor-neutral link layer
protocol in the Internet Protocol Suite used by network devices for
advertising their identity, capabilities, and neighbors on an IEEE 802
local area network, principally wired Ethernet.
This patch introduces an LLDP interface, implemented using the lldpad
service & tool.
Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: Ia96dbf46fa656de6c12d495406715519a3d25439
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
(cherry picked from commit 7b47fe3bbac7dd1e126d55b8064f6807819caf5e)
---
M configure.ac
M lib/vdsm/network/Makefile.am
A lib/vdsm/network/lldp/Makefile.am
A lib/vdsm/network/lldp/__init__.py
A lib/vdsm/network/lldp/lldpad.py
A lib/vdsm/network/lldpad/Makefile.am
A lib/vdsm/network/lldpad/__init__.py
A lib/vdsm/network/lldpad/lldptool.py
M static/usr/lib/systemd/system/vdsmd.service.in
A tests/network/lldpad_test.py
M tests/network/nettestlib.py
M vdsm.spec.in
12 files changed, 605 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/80187
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia96dbf46fa656de6c12d495406715519a3d25439
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[ovirt-4.1]: net: Enable LLDP on NICs
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80192 )
Change subject: net: Enable LLDP on NICs
......................................................................
net: Enable LLDP on NICs
lldpad has to be configured to provide LLDP on network interfaces.
This change activates LLDP on all NICs.
Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: I6cc0cc21a189bcdcff3f4ac3ad97620ed4ff8f50
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
(cherry picked from commit 53d332fa38bb1e4d75dbe9a7760d6e9e961cdde4)
---
M lib/vdsm/network/initializer.py
1 file changed, 20 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/80192
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6cc0cc21a189bcdcff3f4ac3ad97620ed4ff8f50
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[ovirt-4.1]: net: Introduce network initializer module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80327 )
Change subject: net: Introduce network initializer module
......................................................................
net: Introduce network initializer module
In following commit, the network initialization will require
multiple calls to privileged initialization functions. To avoid
the details of initialization of privileged network components
in supervdsmServer, this patch moves the initialization of
privileged network components to network.initializer.
Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: Id9a78d24b6c1cb247397433e02c0bae3e1e7852a
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
M lib/vdsm/network/Makefile.am
A lib/vdsm/network/initializer.py
M vdsm.spec.in
M vdsm/supervdsmServer
4 files changed, 29 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/80327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9a78d24b6c1cb247397433e02c0bae3e1e7852a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
6 years, 9 months
Change in vdsm[ovirt-4.1]: net: Report empty LLDP TLV lists for operationally-down inte...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80390 )
Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces
......................................................................
net: Report empty LLDP TLV lists for operationally-down interfaces
Before this patch, a single interface that was never monitored by lldpad
had caused the API level to fail, blocking information about
properly-enabled interfaces.
This change reports interfaces being not in state UP as not
enabled for LLDP with an empty list of TLVs.
Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
(cherry picked from commit 347eec3c024c76405e60d97f53ef312614797530)
---
M lib/vdsm/network/lldp/info.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/80390
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[ovirt-4.1]: net: Add info lldp to lldp
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80193 )
Change subject: net: Add info lldp to lldp
......................................................................
net: Add info lldp to lldp
lldp is extended to provide informations received by LLDP.
The provided lldp information can be restricted by a filter.
The only implemented filter criteria is to restrict the lldp
information by a list of NIC names received the LLDP information.
Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: I9102e4a52de954a97bf0fb7bbb6e85ffd3d992b5
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
(cherry picked from commit c859c274ad1de001b0600baf874f4547c13cbbcc)
---
M lib/vdsm/network/api.py
A lib/vdsm/network/lldp/info.py
2 files changed, 52 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/80193
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9102e4a52de954a97bf0fb7bbb6e85ffd3d992b5
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[ovirt-4.1]: network: add driverloader module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80186 )
Change subject: network: add driverloader module
......................................................................
network: add driverloader module
DriverLoader class provides tools to gather and provide drivers
(interface implementations).
Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: I8609f81f3b38f5f88f46c0d020de2b16da26adbd
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
Signed-off-by: Petr Horáček <phoracek(a)redhat.com>
(cherry picked from commit 4b40a62ab25fdaca9b23d8121ab00d35e9f76ca4)
---
M lib/vdsm/network/Makefile.am
A lib/vdsm/network/driverloader.py
A tests/network/driverloader_test.py
M vdsm.spec.in
4 files changed, 82 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/80186
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8609f81f3b38f5f88f46c0d020de2b16da26adbd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[ovirt-4.1]: network: add driverloader module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: add driverloader module
......................................................................
Patch Set 3: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/80186
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8609f81f3b38f5f88f46c0d020de2b16da26adbd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months