Change in vdsm[master]: net: Extract ethtool to its own module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Extract ethtool to its own module
......................................................................
Patch Set 5: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/80068
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b5b4a89e8fa6000bcd724d070d51d46d622da0c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: net tests: Run functional tests using pytest
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79727 )
Change subject: net tests: Run functional tests using pytest
......................................................................
net tests: Run functional tests using pytest
Enable the network functional tests to be run using pytest.
The existing marking and assertion of the tests have been
converted from nose to pytest.
There is no change in the unit and integration test run.
In order to run the network functional tests:
pytest -m legacy_switch network/functional
pytest -m ovs_switch network/functional
To run all functional tests except the ovsdpdk ones:
pytest -m "not ovsdpdk_switch" network/functional
Note: pytest needs to be installed on the system (pip install pytest).
Change-Id: I1de97fc245bd11402f52f5cc2e981314e2050b53
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M automation/check-merged.sh
M tests/network/functional/bond_basic_test.py
M tests/network/functional/dhclient_test.py
M tests/network/functional/dns_test.py
M tests/network/functional/dpdk_test.py
M tests/network/functional/net_basic_test.py
M tests/network/functional/net_qos_test.py
M tests/network/functional/net_with_bond_test.py
M tests/network/functional/netfunctestlib.py
M tests/network/functional/netrestore_test.py
M tests/network/functional/rollback_test.py
M tests/network/functional/static_ip_test.py
M tests/network/functional/switch_type_change_test.py
13 files changed, 474 insertions(+), 647 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79727
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1de97fc245bd11402f52f5cc2e981314e2050b53
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: net tests: Define switch type parametrize at netfunctestlib
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80457 )
Change subject: net tests: Define switch type parametrize at netfunctestlib
......................................................................
net tests: Define switch type parametrize at netfunctestlib
Several parametrize definitions are common to multiple functional test
modules and their definition can be moved to the test lib.
This patch handles the switch type parametrize, future patches will
define new ones to serve the tests.
Change-Id: Id4b78847a6950660e1b30c0d7e7d4a676351b2a8
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M tests/network/functional/bond_basic_test.py
M tests/network/functional/dhclient_test.py
M tests/network/functional/net_basic_test.py
M tests/network/functional/net_with_bond_test.py
M tests/network/functional/netfunctestlib.py
M tests/network/functional/rollback_test.py
M tests/network/functional/static_ip_test.py
7 files changed, 20 insertions(+), 22 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/80457
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4b78847a6950660e1b30c0d7e7d4a676351b2a8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: net tests: Relocate network (new) functional tests to its ow...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79725 )
Change subject: net tests: Relocate network (new) functional tests to its own folder
......................................................................
net tests: Relocate network (new) functional tests to its own folder
The functional tests are not mixed with other test types (unit and
integration), therefore, moving them to a seperated folder will remove
some uneeded complexity in choosing which tests should run.
Running the unit & integration tests has not changed.
Running the functional requires these commands:
./run_tests.sh -a switch=legacy network/functional/*_test.py
./run_tests.sh -a switch=ovs network/functional/*_test.py
For running legacy, ovs and switch type change tests (but not dpdk ones):
./run_tests.sh -A "switch!='ovs-dpdk'" network/functional/*_test.py
This patch is one step forward in moving all networking tests
to py.test.
Change-Id: I7bd98f89b2e32f4011465574c54b8b7e99282a4c
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M automation/check-merged.sh
M configure.ac
M tests/network/Makefile.am
A tests/network/functional/Makefile.am
C tests/network/functional/__init__.py
R tests/network/functional/bond_basic_test.py
R tests/network/functional/dhclient_test.py
R tests/network/functional/dns_test.py
R tests/network/functional/dpdk_test.py
R tests/network/functional/net_basic_test.py
R tests/network/functional/net_qos_test.py
R tests/network/functional/net_with_bond_test.py
R tests/network/functional/netfunctestlib.py
R tests/network/functional/netrestore_test.py
R tests/network/functional/rollback_test.py
R tests/network/functional/static_ip_test.py
R tests/network/functional/switch_type_change_test.py
M tests/run_tests_local.sh.in
M vdsm.spec.in
19 files changed, 75 insertions(+), 78 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79725
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bd98f89b2e32f4011465574c54b8b7e99282a4c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: net tests: Define switch type parametrize at netfunctestlib
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Define switch type parametrize at netfunctestlib
......................................................................
Patch Set 3: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/80457
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4b78847a6950660e1b30c0d7e7d4a676351b2a8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: net tests: Run functional tests using pytest
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Run functional tests using pytest
......................................................................
Patch Set 12: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/79727
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1de97fc245bd11402f52f5cc2e981314e2050b53
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: net tests: Relocate network (new) functional tests to its ow...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Relocate network (new) functional tests to its own folder
......................................................................
Patch Set 7: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/79725
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bd98f89b2e32f4011465574c54b8b7e99282a4c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: virt: Make sure all hotunplug calls update domain descriptor
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80609 )
Change subject: virt: Make sure all hotunplug calls update domain descriptor
......................................................................
virt: Make sure all hotunplug calls update domain descriptor
NIC and host device hot unplug calls don't update domain descriptor after the
hot unplug has been completed. Apparently this had had no bad consequences
until we started to use Engine XML and then the domain XML reported to Engine
and actual state of the VM got out of sync. This patch adds the missing update
calls.
Change-Id: Ia6679724d38894958ae09e249b4e1fe99e2cc7ce
Bug-Url: https://bugzilla.redhat.com/1480949
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M lib/vdsm/virt/vm.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Arik Hadas: Looks good to me, but someone else must approve
Michal Skrivanek: Looks good to me, but someone else must approve
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/80609
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6679724d38894958ae09e249b4e1fe99e2cc7ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: virt: Make sure all hotunplug calls update domain descriptor
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Make sure all hotunplug calls update domain descriptor
......................................................................
Patch Set 1: Code-Review+2
Sounds legit, raising scores.
--
To view, visit https://gerrit.ovirt.org/80609
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6679724d38894958ae09e249b4e1fe99e2cc7ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[ovirt-4.1]: net: Wait for vlan link creation when bond-vlan-dhcp is used
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80607 )
Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used
......................................................................
net: Wait for vlan link creation when bond-vlan-dhcp is used
In a setup with a bridgeless network that has bond, vlan and DHCP, the
ifup action is performed in a nonblocking manner and may cause a race
where the vlan link is assumed to exist but the ifup has not yet
executed.
This patch introduces a wait-for-link mechanism for this specific scenario.
Change-Id: I3b638ec5b3fe974be04d3e62437553262978f587
Bug-Url: https://bugzilla.redhat.com/1479829
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/netlink/waitfor.py
2 files changed, 55 insertions(+), 15 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/80607
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b638ec5b3fe974be04d3e62437553262978f587
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months