Change in vdsm[ovirt-4.1]: net: Report empty LLDP TLV lists for operationally-down inte...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces
......................................................................
Patch Set 5:
ci please build
--
To view, visit https://gerrit.ovirt.org/80390
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[ovirt-4.1]: net: Introduce network initializer module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has removed gerrit-hooks from this change. ( https://gerrit.ovirt.org/80327 )
Change subject: net: Introduce network initializer module
......................................................................
Removed reviewer gerrit-hooks with the following votes:
* Verified-1 by gerrit-hooks <automation(a)ovirt.org>
--
To view, visit https://gerrit.ovirt.org/80327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Id9a78d24b6c1cb247397433e02c0bae3e1e7852a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
6 years, 9 months
Change in vdsm[master]: net tests func: Fix IPv4 default route assertion
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80777 )
Change subject: net tests func: Fix IPv4 default route assertion
......................................................................
net tests func: Fix IPv4 default route assertion
The request flag of defaultRoute is not directly related to the net caps
property of ipv4defaultroute.
ipv4defaultroute is true when the network gateway is also the host
default route.
However, a request with defaultRoute set and no gateway is valid,
resulting with a false ipv4defaultroute.
This patch updates the assertion check to be in sync with the
described logic.
Change-Id: I66ee5173261c84845b325b0b0df3fc91aaf02510
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M tests/network/functional/netfunctestlib.py
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/80777
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66ee5173261c84845b325b0b0df3fc91aaf02510
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[master]: net tests: Setup a network marked with default route but no GW
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Setup a network marked with default route but no GW
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/80739/5//COMMIT_MSG
Commit Message:
PS5, Line 9: expose
the problem is not immediately exposed to the reader. can you elaborate with a comment?
--
To view, visit https://gerrit.ovirt.org/80739
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40973e3783b2b9ae8e8f5c1eda0b8998c93c0aa1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 9 months
Change in vdsm[master]: net tests func: Fix IPv4 default route assertion
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests func: Fix IPv4 default route assertion
......................................................................
Patch Set 3: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/80777
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66ee5173261c84845b325b0b0df3fc91aaf02510
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[master]: vdsm.tool.service: unbreak tool.service
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: vdsm.tool.service: unbreak tool.service
......................................................................
vdsm.tool.service: unbreak tool.service
In commit 53a2562 I have avoided execCmd splitting its output to lines,
but I ignored a case where the split was actually used. I do not yet
understand how did this passed my verification.
Change-Id: I494871fc2834291143f7dc4c16ccc507ad5a1778
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/service.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/80908/1
diff --git a/lib/vdsm/tool/service.py b/lib/vdsm/tool/service.py
index 957e777..fdd1b11 100644
--- a/lib/vdsm/tool/service.py
+++ b/lib/vdsm/tool/service.py
@@ -116,7 +116,7 @@
# If unit file type was specified, don't override it.
if srvName.count('.') < 1:
fullName = srvName + ".service"
- for line in out:
+ for line in out.splitlines():
if fullName == line.split(" ", 1)[0]:
return systemctlFun(fullName)
raise ServiceNotExistError("%s is not native systemctl service" %
--
To view, visit https://gerrit.ovirt.org/80908
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I494871fc2834291143f7dc4c16ccc507ad5a1778
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 9 months
Change in vdsm[master]: tests: improve faking
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80756 )
Change subject: tests: improve faking
......................................................................
tests: improve faking
This patch avoids this error due to insufficient faking
AttributeError: 'NoneType' object has no attribute 'notify'
Change-Id: Idee9d3fa1aa9b809a65b04b7972f70d6af848a0c
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M tests/virttests/seal_job_test.py
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/80756
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idee9d3fa1aa9b809a65b04b7972f70d6af848a0c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[master]: vhostuser: convert macAddr to string
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vhostuser: convert macAddr to string
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/80066/3/lib/vdsm/virt/vmdevices/network.py
File lib/vdsm/virt/vmdevices/network.py:
Line 298: supervdsm.getProxy().add_ovs_vhostuser_port(
Line 299: ovs_bridge, port, socket_path)
Line 300:
Line 301: def _get_vhostuser_port_name(self):
Line 302: return str(uuid.uuid3(uuid.UUID(self.vmid), str(self.macAddr)))
I don't understand how this casting is required here but not in other users of self.macAddr. What is the complete value of macAddr provided from Engine? How is this related to the host being RHEL-7.4?
Line 303:
Line 304: def _set_parameters_filter(self, filter):
Line 305: for name, value in self._filter_parameter_map():
Line 306: filter.appendChildWithArgs('parameter', name=name, value=value)
--
To view, visit https://gerrit.ovirt.org/80066
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b4d11a154ffd88523b3d7b19ac87891aac2fba2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 9 months
Change in vdsm[master]: checkimages hook: avoid using execCmd(sync=False)
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: checkimages hook: avoid using execCmd(sync=False)
......................................................................
checkimages hook: avoid using execCmd(sync=False)
I would like to move hooking.py to the common package. However, common
does not have the complex execCmd, and is not likely to ever have
something with sync=False. This patch reimplements exec-with-timeout
using threading.Timer instead of sync=False.
Change-Id: I2ec70891901a0473f5a863ca8ffd0c1df8046962
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm_hooks/checkimages/before_vm_start.py
1 file changed, 12 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/80212/1
diff --git a/vdsm_hooks/checkimages/before_vm_start.py b/vdsm_hooks/checkimages/before_vm_start.py
index 31b123d..8dbcdb4 100755
--- a/vdsm_hooks/checkimages/before_vm_start.py
+++ b/vdsm_hooks/checkimages/before_vm_start.py
@@ -4,7 +4,10 @@
import sys
import traceback
import fcntl
+import signal
+import subprocess
import struct
+import threading
import hooking
BLKGETSIZE64 = 0x80081272 # Obtain device size in bytes
@@ -75,18 +78,20 @@
# Check the image using qemu-img. Enforce check termination
# on timeout expiration
- p = hooking.execCmd(cmd, raw=True, sync=False)
+ p = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE)
+ t = threading.Timer(timeout, p.kill)
+ t.start()
- if not p.wait(timeout):
- p.kill()
+ ((out, err), rc) = (p.communicate(), p.returncode)
+
+ t.cancel()
+
+ if rc == -signal.SIGKILL:
sys.stderr.write('checkimages: %s image check operation timed out.' %
path)
sys.stderr.write('Increate timeout or check image availability.')
sys.exit(2)
-
- ((out, err), rc) = (p.communicate(), p.returncode)
-
- if rc == 0:
+ elif rc == 0:
sys.stderr.write('checkimages: %s image check returned: %s\n' %
(path, out))
else:
--
To view, visit https://gerrit.ovirt.org/80212
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ec70891901a0473f5a863ca8ffd0c1df8046962
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 9 months
Change in vdsm[master]: hooking: move to lib
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: hooking: move to lib
......................................................................
Patch Set 1:
are you should its working? it failed..
--
To view, visit https://gerrit.ovirt.org/80842
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8d7ac3d8730b3961e420936536f3ee5a055d336
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months