Change in vdsm[ovirt-4.1]: net: Wait for vlan link creation when bond-vlan-dhcp is used
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/80607
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b638ec5b3fe974be04d3e62437553262978f587
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: net: Wait for vlan link creation when bond-vlan-dhcp is used
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80505 )
Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used
......................................................................
net: Wait for vlan link creation when bond-vlan-dhcp is used
In a setup with a bridgeless network that has bond, vlan and DHCP, the
ifup action is performed in a nonblocking manner and may cause a race
where the vlan link is assumed to exist but the ifup has not yet
executed.
This patch introduces a wait-for-link mechanism for this specific scenario.
Change-Id: I3b638ec5b3fe974be04d3e62437553262978f587
Bug-Url: https://bugzilla.redhat.com/1479829
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/netlink/waitfor.py
2 files changed, 55 insertions(+), 15 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/80505
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b638ec5b3fe974be04d3e62437553262978f587
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: net: Wait for vlan link creation when bond-vlan-dhcp is used
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/80505
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b638ec5b3fe974be04d3e62437553262978f587
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[ovirt-4.1]: m2cutils: fix a typo in SSL_OP_NO_TLSv1_1 constant
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/80586 )
Change subject: m2cutils: fix a typo in SSL_OP_NO_TLSv1_1 constant
......................................................................
m2cutils: fix a typo in SSL_OP_NO_TLSv1_1 constant
SSL_OP_NO_TLSv1_1 is missing a zero, causing ssl not to exclude
TLSv1.1 protocol.
Label: ovirt-4.1-only
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
Change-Id: I88018f3f73f420d25a7eb0f22ffa8ba56049dd68
Bug-Url: https://bugzilla.redhat.com/1473344
---
M lib/vdsm/m2cutils.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/80586
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88018f3f73f420d25a7eb0f22ffa8ba56049dd68
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[ovirt-4.1]: m2cutils: fix a typo in SSL_OP_NO_TLSv1_1 constant
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has removed a vote on this change.
Change subject: m2cutils: fix a typo in SSL_OP_NO_TLSv1_1 constant
......................................................................
Removed Verified-1 by gerrit-hooks <automation(a)ovirt.org>
--
To view, visit https://gerrit.ovirt.org/80586
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I88018f3f73f420d25a7eb0f22ffa8ba56049dd68
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[ovirt-4.1]: m2cutils: fix a typo in SSL_OP_NO_TLSv1_1 constant
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: m2cutils: fix a typo in SSL_OP_NO_TLSv1_1 constant
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/80586
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88018f3f73f420d25a7eb0f22ffa8ba56049dd68
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: net: Wait for vlan link creation when bond-vlan-dhcp is used
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used
......................................................................
Patch Set 4:
which process would you like to wait for? the vdsm-requested ifup? the dhclient run by it? how long would you wait for it?
When testing asynchronous code, your test has to have a timeout. If Vdsm does not set a dhcp address within 60 seconds when the dhcp server is sitting on the same host, we can declare that this is a failure.
--
To view, visit https://gerrit.ovirt.org/80505
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b638ec5b3fe974be04d3e62437553262978f587
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: net: don't use properties internally.
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80218 )
Change subject: net: don't use properties internally.
......................................................................
net: don't use properties internally.
IPAddressData's __repr__ device, scope, and flags
properties aren't returning modified variations
of their attributes and as such there is no need
to use them over the actual attributes.
Change-Id: I902490b576f630b35dabe6866181be1b554dccfe
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M lib/vdsm/network/ip/address/__init__.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Leon Goldberg: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80218
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I902490b576f630b35dabe6866181be1b554dccfe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: net: Remove redundant hasattr calls.
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80217 )
Change subject: net: Remove redundant hasattr calls.
......................................................................
net: Remove redundant hasattr calls.
IPAddressData __repr__ contains redundant hasattr calls
for attributes that are guaranteed to be present.
Change-Id: I8678f227ee5c60011cc28bd390e3a616beb465d5
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M lib/vdsm/network/ip/address/__init__.py
1 file changed, 2 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Leon Goldberg: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80217
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8678f227ee5c60011cc28bd390e3a616beb465d5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: net: Wait for vlan link creation when bond-vlan-dhcp is used
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/80505/4//COMMIT_MSG
Commit Message:
Line 8:
Line 9: In a setup with a bridgeless network that has bond, vlan and DHCP, the
Line 10: ifup action is performed in a nonblocking manner and may cause a race
Line 11: where the vlan link is assumed to exist but the ifup has not yet
Line 12: executed.
> Because we do not have at the moment any nonblocking DHCP functional test i
How about the following test:
* ask Vdsm for a non-blocking dhcp.
* assert the vdsm returns success
* use waitfor to wait until dnsmask give an address to dhclient and dhcliet applies it to kernel.
* declare success
Line 13:
Line 14: This patch introduces a wait-for-link mechanism for this specific scenario.
Line 15:
Line 16: Change-Id: I3b638ec5b3fe974be04d3e62437553262978f587
--
To view, visit https://gerrit.ovirt.org/80505
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b638ec5b3fe974be04d3e62437553262978f587
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months