From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: m2cutils: support excluding OP_NO_TLSv1_2
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/80363
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f571f74486aa3974c53567d79a8441e9b157351
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Report empty LLDP TLV lists for operational down interfaces
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/80339/4//COMMIT_MSG
Commit Message:
Line 4: Commit: Dominik Holler <dholler(a)redhat.com>
Line 5: CommitDate: 2017-08-08 09:10:55 +0200
Line 6:
Line 7: net: Report empty LLDP TLV lists for operational down interfaces
Line 8:
I must agree with Edy; the text is not very clear.
I think what you mean is:
"""
This change reports empty LLDP info for interfaces that are not UP.
Before this patch, a single operationally-down interface had caused the API level to fail, blocking information about properly-enabled interfaces.
"""
please correct my text if I misunderstood yours.
Line 9: Reading LLDP information from an interface, which is not in state UP,
Line 10: may result previously in an error on VDSM API level, even if the request
Line 11: includes other interfaces, which are up.
Line 12: Without the change, in the sequence interface down, enable LLDP and
--
To view, visit https://gerrit.ovirt.org/80339
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79668 )
Change subject: ssl: handle handshake errors
......................................................................
ssl: handle handshake errors
There are two possible errors (sslerror and socket.error) which are
raised during ssl handshake that need to be handled. We do not want
to see unhandled error backtraces in the logs which could easily
generate enourmos amount of logs when malicious client exploit it.
We log now only the occurence of the error and the offending IP address
that caused the error.
We fix the issue by handling both errors and cleanly closing file
descriptor.
Bug-url: https://bugzilla.redhat.com/1473295
Change-Id: I99cfa35e608f429640455c35495be1783854e3da
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/vdsm/sslutils.py
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79668
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99cfa35e608f429640455c35495be1783854e3da
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80362 )
Change subject: net: Hide zero-mac nics only if they are identified as vmfex
......................................................................
net: Hide zero-mac nics only if they are identified as vmfex
zero-mac interfaces which have been identified as VF have been assumed
to be vmfex interfaces.
There seem to be other VF interfaces which appear with zero-mac that are
not vmfex.
To make it more specific, the vmfex driver name is examined ('enic').
zero-mac interfaces that are not vmfex are now reported as nics by the
network caps.
Change-Id: I14bca017c9018c7ff50d9cb84311d0d5d655ec3d
Bug-Url: https://bugzilla.redhat.com/1474638
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/ipwrapper.py
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/80362
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14bca017c9018c7ff50d9cb84311d0d5d655ec3d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Hide zero-mac nics only if they are identified as vmfex
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/80362
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14bca017c9018c7ff50d9cb84311d0d5d655ec3d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: m2cutils: support excluding OP_NO_TLSv1_2
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/80363
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f571f74486aa3974c53567d79a8441e9b157351
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has removed a vote on this change.
Change subject: m2cutils: support excluding OP_NO_TLSv1_2
......................................................................
Removed Verified-1 by gerrit-hooks <automation(a)ovirt.org>
--
To view, visit https://gerrit.ovirt.org/80363
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7f571f74486aa3974c53567d79a8441e9b157351
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: handle handshake errors
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79668
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99cfa35e608f429640455c35495be1783854e3da
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79925 )
Change subject: build: remove constants.py from dist package
......................................................................
build: remove constants.py from dist package
Recently constants.py was moved to lib/vdsm/common. This was done by
commit f63269e9fa2b1a31e6d9673f8e3337eeacbd0332. However, because of
existing rule in Makefile.am this file was mistakenly included into
dist package. As a result constants.py was not recreated during RPM
builds which resulted in broken RPMs (constants.py contained invalid
paths).
lib/vdsm/common/Makefile.am contained dist_* rule that includes all
'*.py' into dist package. Note that files listed in the nodist_* rule
are not taken into account during 'make dist'.
This change does two things:
1) it modifies the dist_* rule to contain all '*.py' minus the files
listed in nodist_* rule
2) test is added to check-patch.sh to make sure no file generated from
.in file is included in the dist package
ad 2) There are several exceptions that we seem to include in dist
package on purpose. I don't really believe that including any of those
files (except maybe vdsm.spec) is necessary, but I did not investigate.
This can be improved in subsequent patches.
Change-Id: I36820d3c458c5d162dcb8fbe2baf1c9647c9032d
Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
---
M automation/check-patch.sh
M lib/vdsm/common/Makefile.am
2 files changed, 44 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Verified
--
To view, visit https://gerrit.ovirt.org/79925
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36820d3c458c5d162dcb8fbe2baf1c9647c9032d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>